[Django] #32754: catch_all_view from admin does not support FORCE_SCRIPT_NAME

[Django]

#32754: catch_all_view from admin does not support FORCE_SCRIPT_NAME
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
SlavaSkvortsov |
Type: Bug | Status: new
Component: | Version: 3.2
contrib.admin | Keywords: FORCE_SCRIPT_NAME
Severity: Normal | catch_all_view final_catch_all_view
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`catch_all_view` returns redirect to `'%s/' % request.path_info` (script
name cut off there) instead of `'%s/' % request.path` (with the script
name)

--
Ticket URL: <https://code.djangoproject.com/ticket/32754>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#32754: catch_all_view() does not support FORCE_SCRIPT_NAME.
-------------------------------------+-------------------------------------
Reporter: SlavaSkvortsov | Owner:
| SlavaSkvortsov
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Release blocker | Resolution:
Keywords: FORCE_SCRIPT_NAME | Triage Stage: Accepted
catch_all_view |
final_catch_all_view |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* status: new => assigned
* severity: Normal => Release blocker
* cc: Jon Dufresne (added)
* owner: nobody => SlavaSkvortsov
* stage: Unreviewed => Accepted

Comment:

Thanks for the report, good catch! Bug in
ba31b0103442ac891fb3cb98f316781254e366c3.

--
Ticket URL: <https://code.djangoproject.com/ticket/32754#comment:1>

[Django]

#32754: catch_all_view() does not support FORCE_SCRIPT_NAME.
-------------------------------------+-------------------------------------
Reporter: SlavaSkvortsov | Owner:
| SlavaSkvortsov
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Release blocker | Resolution:
Keywords: FORCE_SCRIPT_NAME | Triage Stage: Accepted
catch_all_view |
final_catch_all_view |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by SlavaSkvortsov:

Old description:

> `catch_all_view` returns redirect to `'%s/' % request.path_info` (script
> name cut off there) instead of `'%s/' % request.path` (with the script
> name)

New description:

`catch_all_view` returns redirect to `'%s/' % request.path_info` (script
name cut off there) instead of `'%s/' % request.path` (with the script
name)

Patch - https://github.com/django/django/pull/14404

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32754#comment:2>

[Django]

#32754: catch_all_view() does not support FORCE_SCRIPT_NAME.
-------------------------------------+-------------------------------------
Reporter: SlavaSkvortsov | Owner:
| SlavaSkvortsov
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Release blocker | Resolution:
Keywords: FORCE_SCRIPT_NAME | Triage Stage: Accepted
catch_all_view |
final_catch_all_view |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by SlavaSkvortsov):

Thank you for a quick answer!

I wrote a patch [https://github.com/django/django/pull/14404 here]

--
Ticket URL: <https://code.djangoproject.com/ticket/32754#comment:3>

[Django]

#32754: catch_all_view() does not support FORCE_SCRIPT_NAME.
-------------------------------------+-------------------------------------
Reporter: SlavaSkvortsov | Owner:
| SlavaSkvortsov
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.2
Severity: Release blocker | Resolution:

Keywords: FORCE_SCRIPT_NAME | Triage Stage: Ready for
catch_all_view | checkin
final_catch_all_view |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/32754#comment:4>

[Django]

#32754: catch_all_view() does not support FORCE_SCRIPT_NAME.
-------------------------------------+-------------------------------------
Reporter: SlavaSkvortsov | Owner:
| SlavaSkvortsov

Type: Bug | Status: closed
Component: contrib.admin | Version: 3.2
Severity: Release blocker | Resolution: fixed

Keywords: FORCE_SCRIPT_NAME | Triage Stage: Ready for
catch_all_view | checkin
final_catch_all_view |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"f7691d4812c578e696635718e67639d2e08eac40" f7691d4]:
{{{
#!CommitTicketReference repository=""
revision="f7691d4812c578e696635718e67639d2e08eac40"
Fixed #32754 -- Made AdminSite.catch_all_view() respect SCRIPT_NAME.

Regression in ba31b0103442ac891fb3cb98f316781254e366c3.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32754#comment:5>

[Django]

#32754: catch_all_view() does not support FORCE_SCRIPT_NAME.
-------------------------------------+-------------------------------------
Reporter: SlavaSkvortsov | Owner:
| SlavaSkvortsov
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.2
Severity: Release blocker | Resolution: fixed
Keywords: FORCE_SCRIPT_NAME | Triage Stage: Ready for
catch_all_view | checkin
final_catch_all_view |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"ce78bc9808db279ab5db1b285518ca3eb189419c" ce78bc98]:
{{{
#!CommitTicketReference repository=""
revision="ce78bc9808db279ab5db1b285518ca3eb189419c"
[3.2.x] Fixed #32754 -- Made AdminSite.catch_all_view() respect
SCRIPT_NAME.

Regression in ba31b0103442ac891fb3cb98f316781254e366c3.

Backport of f7691d4812c578e696635718e67639d2e08eac40 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32754#comment:6>