[Django] #34045: Admin changelist checkboxes do not have labels
Django
-----------------------------------------+------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/34045>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Unreviewed => Accepted
Comment:
I guess we need `aria-label`s. Tentatively accepted.
I'd be grateful for any description, by the way 😉.
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:1>
Django
-------------------------------+------------------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Old description:
New description:
This is failing WCAG level A so is quite fundamental. Screen reader users
currently have no way to know what these checkboxes are for. We should add
some kind of screenreader friendly label to make it clear you're selecting
this row for running an action.
I'm not quite sure on the text. As the checkbox appears before the text
describing the row I'm not sure if it'd need any extra info on the label -
I suppose if we just added the label we'd be asking the user to select
something that they don't yet know what it is?
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:2>
Django
-------------------------------+------------------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
* Attachment "Screenshot 2022-09-30 at 12.37.20 AM.png" added.
Selection checkbox
--
Ticket URL: <https://code.djangoproject.com/ticket/34045>
Django
Reporter: Tom Carrick | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+----------------------------------------
Changes (by Neeraj Kumar):
* owner: nobody => Neeraj Kumar
* status: new => assigned
* ui_ux: 0 => 1
Comment:
Added a screenshot, we can use "Select all" text for checkbox label
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:3>
Django
Reporter: Tom Carrick | Owner: Durval Carvalho
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Durval Carvalho):
* owner: Neeraj Kumar => Durval Carvalho
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:4>
Django
-------------------------------+-------------------------------------------
Reporter: Tom Carrick | Owner: Durval Carvalho
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+-------------------------------------------
Comment (by Durval Carvalho):
Hey, guys!
I was working on this ticket and Mariusz Felisiak wrote that each line
should have a defined aria label [¹]. But I'm not sure which text I should
use. Maybe the str(instance)? What do you think?
[¹] https://github.com/django/django/pull/16515#issuecomment-1410872283
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:5>
Django
-------------------------------+-------------------------------------------
Reporter: Tom Carrick | Owner: Durval Carvalho
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+-------------------------------------------
* cc: Sarah Abderemane (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:6>
Django
-------------------------------+-------------------------------------------
Reporter: Tom Carrick | Owner: Durval Carvalho
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+-------------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/16515 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:7>
Django
-------------------------------+-------------------------------------------
Reporter: Tom Carrick | Owner: Durval Carvalho
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+-------------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:8>
Django
Reporter: Tom Carrick | Owner: Durval
| Carvalho
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Durval
| Carvalho
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"85366fbca723c9b37d0ac9db1d44e3f1cb188db2" 85366fb]:
{{{
#!CommitTicketReference repository=""
revision="85366fbca723c9b37d0ac9db1d44e3f1cb188db2"
Fixed #34045 -- Improved accessibility of selecting items in admin
changelist.
This adds "aria-label".
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Durval
| Carvalho
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
In [changeset:"182f262b15882649bbc39d769f9b721cf3660f6f" 182f262b]:
{{{#!CommitTicketReference repository=""
revision="182f262b15882649bbc39d769f9b721cf3660f6f"
Fixed #35606, Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox
for models with a __html__ method.
Thank you Claude Paroz for the report.
Regression in 85366fbca723c9b37d0ac9db1d44e3f1cb188db2.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Durval
| Carvalho
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):
{{{#!CommitTicketReference repository=""
revision="5eef80b56e8b3635a071d644fcc9acacdd71025c"
[5.1.x] Fixed #35606, Refs #34045 -- Fixed rendering of
Thank you Claude Paroz for the report.
Regression in 85366fbca723c9b37d0ac9db1d44e3f1cb188db2.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34045#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Durval
| Carvalho
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):
{{{#!CommitTicketReference repository=""
revision="c3d3af8ea369e16263c8330b1745ba101d1c8d62"
[5.0.x] Fixed #35606, Refs #34045 -- Fixed rendering of
Thank you Claude Paroz for the report.
Regression in 85366fbca723c9b37d0ac9db1d44e3f1cb188db2.
Backport of 182f262b15882649bbc39d769f9b721cf3660f6f from main.
}}}
--