[Django] #34628: RelatedFieldWidgetWrapper link icons are very hard to see

0 views
Skip to first unread message

Django

unread,
Jun 2, 2023, 11:43:36 AM6/2/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: nmenezes0
Colas |
Type: | Status: assigned
Uncategorized |
Component: | Version: 4.2
contrib.admin | Keywords: accessibility,
Severity: Normal | color contrast
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
Spotted as part of #34622 – the icons used for RelatedFieldWidgetWrapper
links are very small, too low-contrast, and rely on opacity to convey
their state. Screenshot:


This should be simple to at least incrementally improve upon:

- Make the icons bigger
- Use something else than opacity for the disabled state

--
Ticket URL: <https://code.djangoproject.com/ticket/34628>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 3, 2023, 2:26:57 AM6/3/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
color contrast |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by David Smith):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/16934 PR]

Thibaud did you have a screenshot you were intending to attach?

--
Ticket URL: <https://code.djangoproject.com/ticket/34628#comment:1>

Django

unread,
Jun 3, 2023, 2:52:55 PM6/3/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
color contrast |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* type: Uncategorized => Cleanup/optimization


--
Ticket URL: <https://code.djangoproject.com/ticket/34628#comment:2>

Django

unread,
Jun 4, 2023, 6:31:07 PM6/4/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
color contrast |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* Attachment "icons-hard-to-see.png" added.

Django

unread,
Jun 4, 2023, 6:31:59 PM6/4/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
color contrast |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Old description:

> Spotted as part of #34622 – the icons used for RelatedFieldWidgetWrapper
> links are very small, too low-contrast, and rely on opacity to convey
> their state. Screenshot:
>

> This should be simple to at least incrementally improve upon:
>
> - Make the icons bigger
> - Use something else than opacity for the disabled state

New description:

Spotted as part of #34622 – the icons used for RelatedFieldWidgetWrapper
links are very small, too low-contrast, and rely on opacity to convey
their state. Screenshot:

[[Image(https://code.djangoproject.com/raw-attachment/ticket/34628/icons-
hard-to-see.png)]]

This should be simple to at least incrementally improve upon:

- Make the icons bigger
- Use something else than opacity for the disabled state

--

Comment (by Thibaud Colas):

Thanks David, I got lost with the image management.

--
Ticket URL: <https://code.djangoproject.com/ticket/34628#comment:3>

Django

unread,
Jun 4, 2023, 11:30:18 PM6/4/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
color contrast |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34628#comment:4>

Django

unread,
Jun 12, 2023, 2:35:34 AM6/12/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Ready for
color contrast | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34628#comment:5>

Django

unread,
Jun 12, 2023, 5:21:35 AM6/12/23
to django-...@googlegroups.com
#34628: RelatedFieldWidgetWrapper link icons are very hard to see
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nmenezes0
Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed

Keywords: accessibility, | Triage Stage: Ready for
color contrast | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"1699f8b52ac15f687cc39088401c2641022c71cd" 1699f8b]:
{{{
#!CommitTicketReference repository=""
revision="1699f8b52ac15f687cc39088401c2641022c71cd"
Fixed #34628 -- Improved icons accessibility of related widget wrapper in
admin.

This improves accessibility of icons by making them larger and grayscale
(when not selected).
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34628#comment:6>

Reply all
Reply to author
Forward
0 new messages