Re: [Django] #37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html
-------------------------------------+-------------------------------------
Reporter: Oganes Gambaryan | Owner: MANAS
| MADESHIYA
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by MANAS MADESHIYA):

* owner: (none) => MANAS MADESHIYA
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html
-------------------------------------+-------------------------------------
Reporter: Oganes Gambaryan | Owner: MANAS
| MADESHIYA
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by MANAS MADESHIYA):

* has_patch: 0 => 1

Comment:

I have submitted a PR for this ticket:

PR: https://github.com/django/django/pull/21090

Changes:

- Corrected the placement of `{% endblock %}` in `change_list.html`
- Ensured proper block structure by moving it outside the `changelist-
footer` div
- No functional changes; improves template correctness and readability
--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:5>

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html
-------------------------------------+-------------------------------------

Reporter: Oganes Gambaryan | Owner: Tim
| Graham

Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* owner: MANAS MADESHIYA => Tim Graham
* stage: Accepted => Ready for checkin

Comment:

The original PR stalled because the reporter couldn't understand
indentation. I suggest not to use AI in the future because it seems to
have trouble with things like that.

I submitted my own trivial [https://github.com/django/django/pull/21099
PR]. I didn't feel a test was useful because if we added a test for the
placement of every HTML tag in every template, that would be very onerous.
--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:6>

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html

----------------------------------+--------------------------------------

Reporter: Oganes Gambaryan | Owner: Tim Graham
Type: Bug | Status: assigned

Component: contrib.admin | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

----------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* stage: Ready for checkin => Accepted
* version: dev => 6.0

Comment:

Refs #36366, regression in 3f59711581bd22ebd0f13fb040b15b69c0eee21f

> I didn't feel a test was useful because if we added a test for the
placement of every HTML tag in every template, that would be very onerous.

I agree. Could you add a small release note as I believe the regression
was introduced in 6.0
--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:7>

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html
----------------------------------+--------------------------------------
Reporter: Oganes Gambaryan | Owner: Tim Graham
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0

Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
----------------------------------+--------------------------------------
Changes (by Sarah Boyce):

* severity: Normal => Release blocker

--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:8>

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html

-------------------------------------+-------------------------------------

Reporter: Oganes Gambaryan | Owner: Tim
| Graham
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

Comment:

Done. (I call it a bug rather than a regression since `<div class
="changelist-footer">` is new.)
--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:9>

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html
-------------------------------------+-------------------------------------
Reporter: Oganes Gambaryan | Owner: Tim
| Graham

Type: Bug | Status: closed
Component: contrib.admin | Version: 6.0
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"8d326336c5fba4740114fea5294a7b426c96d65c" 8d326336]:
{{{#!CommitTicketReference repository=""
revision="8d326336c5fba4740114fea5294a7b426c96d65c"
Fixed #37029 -- Corrected placement of </div> in change_list.html's
pagination block.

Bug in 3f59711581bd22ebd0f13fb040b15b69c0eee21f.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:10>

[Django]

#37029: {% block pagination %}'s {% endblock %} misplaced in change_list.html
-------------------------------------+-------------------------------------
Reporter: Oganes Gambaryan | Owner: Tim
| Graham
Type: Bug | Status: closed
Component: contrib.admin | Version: 6.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"69d86004f7b3c9ed223c18998c2b799d1670474f" 69d86004]:
{{{#!CommitTicketReference repository=""
revision="69d86004f7b3c9ed223c18998c2b799d1670474f"
[6.0.x] Fixed #37029 -- Corrected placement of </div> in

change_list.html's pagination block.

Bug in 3f59711581bd22ebd0f13fb040b15b69c0eee21f.

Backport of 8d326336c5fba4740114fea5294a7b426c96d65c from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/37029#comment:11>