Re: [Django] #13060: ManagementForm exception in case of bad prefix should be easier to understand

[Django]

#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-------------------------------------+-------------------------------------
Reporter: Karel | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: formset, | Triage Stage: Accepted
ValidationError, ManagementForm |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* version: => master
* needs_tests: 1 => 0
* easy: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13060#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-------------------------------------+-------------------------------------

Reporter: Karel | Owner: Manav
Type: | Agarwal
Cleanup/optimization | Status: assigned

Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: formset, | Triage Stage: Accepted
ValidationError, ManagementForm |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Manav Agarwal):

* owner: nobody => Manav Agarwal
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/13060#comment:9>

[Django]

#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-------------------------------------+-------------------------------------
Reporter: Karel | Owner: Manav
Type: | Agarwal
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: formset, | Triage Stage: Accepted
ValidationError, ManagementForm |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Manav Agarwal):

We may change the code from :

{{{
raise ValidationError(
_('ManagementForm data is missing or has been tampered
with'),
code='missing_management_form',
)
}}}

to something like:

{{{
raise ValidationError(
_('ManagementForm data is missing or has been tampered
with %s' % form._errors),
code='missing_management_form',
)

}}}
Approvals please.

--
Ticket URL: <https://code.djangoproject.com/ticket/13060#comment:10>

[Django]

#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-------------------------------------+-------------------------------------
Reporter: Karel | Owner: Manav
Type: | Agarwal
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: formset, | Triage Stage: Accepted
ValidationError, ManagementForm |

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* has_patch: 0 => 1
* needs_tests: 0 => 1

Comment:

[https://github.com/django/django/pull/13509 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/13060#comment:11>

[Django]

#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-------------------------------------+-------------------------------------
Reporter: Karel | Owner: Manav
Type: | Agarwal
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:

Keywords: formset, | Triage Stage: Ready for
ValidationError, ManagementForm | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/13060#comment:14>

[Django]

#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-------------------------------------+-------------------------------------
Reporter: Karel | Owner: Manav
Type: | Agarwal

Cleanup/optimization | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: formset, | Triage Stage: Ready for
ValidationError, ManagementForm | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"096b14f0ac8513c5d76c1b693721b6aede18777d" 096b14f0]:
{{{
#!CommitTicketReference repository=""
revision="096b14f0ac8513c5d76c1b693721b6aede18777d"
Fixed #13060 -- Improved error message when ManagementForm data is
missing.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/13060#comment:15>