[Django] #33310: Django admin Select All CSS seems inconsistent on latest 3.2.9 version
Django
------------------------------------------------+------------------------
Reporter: alvaromlg | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
Hello,
First of all I am not sure if this is intended, it's a change happening on
Django 3.2
On Django 3.1 this was the admin styling on Select All
[[Image(https://i.imgur.com/hvIRkis.png)]]
And on Django 3.2 it looks like this:
[[Image(https://i.imgur.com/DyiY43M.png)]]
Is it intended? Javascript doesnt add anymore the "selected" class and
even if you add it manually it doesnt apply the yellow color because the
CSS class just apply the body background color.
If it's intended I think we can refactor and just remove this CSS code at
changelist.css (and maybe in other places) because it's indeed (as the
comment says) not used and its a bit confusing when overriding it for
django admin template overriding purposes.
--
Ticket URL: <https://code.djangoproject.com/ticket/33310>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: alvaromlg | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 3.2
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: Carlton Gibson (added)
* stage: Unreviewed => Accepted
Comment:
Thanks for the report, we
[https://github.com/django/django/pull/14870#issuecomment-923712827
noticed] this change when fixing #33083. I think now it looks better,
feel-free to removed unused CSS class.
--
Ticket URL: <https://code.djangoproject.com/ticket/33310#comment:1>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 3.2
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Mariusz Felisiak):
The same can be removed from `responsive.css`.
--
Ticket URL: <https://code.djangoproject.com/ticket/33310#comment:2>
Django
Reporter: Álvaro Pelegrina | Owner: Álvaro
Fernández | Pelegrina Fernández
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Álvaro Pelegrina Fernández):
* owner: nobody => Álvaro Pelegrina Fernández
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33310#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Álvaro Pelegrina | Owner: Álvaro
Fernández | Pelegrina Fernández
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Álvaro Pelegrina Fernández):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33310#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Álvaro Pelegrina | Owner: Álvaro
Fernández | Pelegrina Fernández
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Álvaro Pelegrina Fernández):
Great, I patches those css files.
This is it's related PR https://github.com/django/django/pull/15117
--
Ticket URL: <https://code.djangoproject.com/ticket/33310#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Álvaro Pelegrina | Owner: Álvaro
Fernández | Pelegrina Fernández
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"98352ddf3a1ccffe8d38ecb34e1a51ed58d29cf3" 98352ddf]:
{{{
#!CommitTicketReference repository=""
revision="98352ddf3a1ccffe8d38ecb34e1a51ed58d29cf3"
Fixed #33310 -- Removed unused rule from admin CSS.
Unused since 30e59705fc3e3e9e8370b965af794ad6173bf92b.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33310#comment:6>