[Django] #27218: Return LogEntry instances from log_addition, log_change, log_deletion

19 views
Skip to first unread message

Django

unread,
Sep 13, 2016, 9:55:33 AM9/13/16
to django-...@googlegroups.com
#27218: Return LogEntry instances from log_addition, log_change, log_deletion
-----------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
For customized `ModelAdmin` classes, it might be handy to have access to
the created LogEntry instances in inherited methods to be able to
customize the logging behavior (django-reversion has a use case for that).

I suggest to return the LogEntry instance from those methods (which
currently don't return anything).

--
Ticket URL: <https://code.djangoproject.com/ticket/27218>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 13, 2016, 10:24:35 AM9/13/16
to django-...@googlegroups.com
#27218: Return LogEntry instances from log_addition, log_change, log_deletion
-------------------------------+------------------------------------

Reporter: claudep | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27218#comment:1>

Django

unread,
Oct 1, 2016, 10:31:08 AM10/1/16
to django-...@googlegroups.com
#27218: Return LogEntry instances from log_addition, log_change, log_deletion
-------------------------------+------------------------------------
Reporter: Claude Paroz | Owner: nobody

Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7330 PR] (with comments for
improvement).

--
Ticket URL: <https://code.djangoproject.com/ticket/27218#comment:2>

Django

unread,
Oct 2, 2016, 6:34:53 PM10/2/16
to django-...@googlegroups.com
#27218: Return LogEntry instances from log_addition, log_change, log_deletion
-------------------------------+------------------------------------
Reporter: Claude Paroz | Owner: nobody

Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by François Freitag):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27218#comment:3>

Django

unread,
Oct 4, 2016, 2:09:30 PM10/4/16
to django-...@googlegroups.com
#27218: Return LogEntry instances from log_addition, log_change, log_deletion
-------------------------------+------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"aa9569fce1b308819039450e3d2b852c37128209" aa9569fc]:
{{{
#!CommitTicketReference repository=""
revision="aa9569fce1b308819039450e3d2b852c37128209"
Fixed #27218 -- Returned LogEntry instances from ModelAdmin.log_*()
methods.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27218#comment:4>

Django

unread,
Oct 5, 2016, 9:19:41 AM10/5/16
to django-...@googlegroups.com
#27218: Return LogEntry instances from log_addition, log_change, log_deletion
-------------------------------+------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: New feature | Status: closed
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"e5f5e8ac17161708b18ac1e88aeedaa1fd7451ec" e5f5e8ac]:
{{{
#!CommitTicketReference repository=""
revision="e5f5e8ac17161708b18ac1e88aeedaa1fd7451ec"
Refs #27218 -- Fixed LogEntry tests on MySQL 5.5.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27218#comment:5>

Reply all
Reply to author
Forward
0 new messages