Re: [Django] #34788: Correct NUMBER_GROUPING in Japan.

7 views
Skip to first unread message

Django

unread,
Aug 21, 2023, 8:24:18 PM8/21/23
to django-...@googlegroups.com
#34788: Correct NUMBER_GROUPING in Japan.
-------------------------------------+-------------------------------------
Reporter: tell-k | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: | Version: 4.2
Internationalization |
Severity: Normal | Resolution:
Keywords: number grouping, | Triage Stage: Accepted
format, japanese |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Hiroki Kiyohara):

Hi. I am a Japanese dev who has contributed to Django in the past.
We always write numbers in the style of `100,000`.
Many Japanese people set NUMBER_GROUPING manually to use intcomma.

--
Ticket URL: <https://code.djangoproject.com/ticket/34788#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 21, 2023, 11:11:26 PM8/21/23
to django-...@googlegroups.com
#34788: Correct NUMBER_GROUPING in Japan.
-------------------------------------+-------------------------------------
Reporter: tell-k | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: | Version: 4.2
Internationalization |
Severity: Normal | Resolution:
Keywords: number grouping, | Triage Stage: Accepted
format, japanese |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by tokibito):

+1
In Japan, the public documents from the government are used the style of
`100,000`.

https://www.bunka.go.jp/seisaku/bunkashingikai/kokugo/hokoku/pdf/93098001_01.pdf

This document specify the style of public documentation.

> p17 I-4 数字の使い方
> イ 大きな数は、三桁ごとにコンマで区切る
> 四桁以上の数は三桁ごとにコンマで区切って書く。
> 例)5,000 62,250 円 1,254,372 人

--
Ticket URL: <https://code.djangoproject.com/ticket/34788#comment:3>

Django

unread,
Aug 21, 2023, 11:27:38 PM8/21/23
to django-...@googlegroups.com
#34788: Correct NUMBER_GROUPING in Japan.
-------------------------------------+-------------------------------------
Reporter: tell-k | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: | Version: 4.2
Internationalization |
Severity: Normal | Resolution:
Keywords: number grouping, | Triage Stage: Ready for
format, japanese | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


Comment:

Hiroki, Shinya, thanks for your confirmation.

[https://github.com/django/django/pull/17180 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34788#comment:4>

Django

unread,
Aug 21, 2023, 11:32:07 PM8/21/23
to django-...@googlegroups.com
#34788: Correct NUMBER_GROUPING in Japan.
-------------------------------------+-------------------------------------
Reporter: tell-k | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: | Version: 4.2
Internationalization |
Severity: Normal | Resolution: fixed

Keywords: number grouping, | Triage Stage: Ready for
format, japanese | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"6934fc3f6eeaecc9363d0949c2f9691940a12121" 6934fc3]:
{{{
#!CommitTicketReference repository=""
revision="6934fc3f6eeaecc9363d0949c2f9691940a12121"
Fixed #34788 -- Corrected NUMBER_GROUPING for Japanese.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34788#comment:5>

Django

unread,
Aug 22, 2023, 2:56:47 AM8/22/23
to django-...@googlegroups.com
#34788: Correct NUMBER_GROUPING in Japan.
-------------------------------------+-------------------------------------
Reporter: tell-k | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: | Version: 4.2
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: number grouping, | Triage Stage: Ready for
format, japanese | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by tell-k):

Mariusz Felisiak, Thank you for your help.

--
Ticket URL: <https://code.djangoproject.com/ticket/34788#comment:6>

Reply all
Reply to author
Forward
0 new messages