Re: [Django] #36829: Missing release note and documentation for change to ClearableFileInput.use_fieldset

[Django]

#36829: Missing release note and documentation for change to
ClearableFileInput.use_fieldset
-------------------------------------+-------------------------------------
Reporter: Johannes Maron | Owner: Johannes
| Maron
Type: Bug | Status: assigned
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: fieldset, legend | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by David Smith):

I'll comment on this ticket and #36828 as a pair. In summary, my view is
to:

- Keep this ticket to revert the change to `ClearableFileInput` in Django
6.0 but keep it in the admin `AdminFileWidget` (i.e. implement Tim's
comment).
- Keep #36828 as a new feature to change the `ClearableFileInput` template
to add `<fieldset>` and `<legend>`. This should be a new feature that can
target 6.1 or later.

My reason for this suggestion is that #35892, which introduced this
change, was specifically aimed at targeting the admin widget. The change
to the default widget, as far as I can tell, was an unintended consequence
of that change and needs further changes to the default template to make
it work. Reverting the change to the default template, but keeping it in
the admin, seems (but I've not specifically tried) like it would be a
straight forward enough change to make.

This will allow us to take more time and to get feedback from the
accessibility team before making changes to the default
`ClearableFileInput` template. Especially as the accessibility team
previously had mixed reviews on the change that would be required --
albeit that was some time ago.
--
Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36829: Missing release note and documentation for change to
ClearableFileInput.use_fieldset
-------------------------------------+-------------------------------------
Reporter: Johannes Maron | Owner: Johannes
| Maron
Type: Bug | Status: assigned
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: fieldset, legend | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Jacob Walls):

Thanks, David. I think that's prudent. I'll review Johannes's PR
implementing Tim's suggestion.
--
Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:10>

[Django]

#36829: Missing release note and documentation for change to
ClearableFileInput.use_fieldset
-------------------------------------+-------------------------------------
Reporter: Johannes Maron | Owner: Johannes
| Maron
Type: Bug | Status: assigned
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: fieldset, legend | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Jacob Walls):

I dug around and found some prior ideation around providing a deprecation
path for widget rendering changes. See ticket:32339#comment:2:

> One issue we have is breaking peoples existing pages if we change the
rendered HTML (so that CSS/JS selectors change for instance).
> Can I point you to #31026, ... If we can get that in, then we'd be able
to document a ''Use this template ... to restore the previous HTML'',
which then would give us room to introduce a more significant change.

Thanks Johannes for implementing #31026 years ago! :-)

Assuming something like that is possible here, I now agree this change
would need to go through a deprecation path.
--
Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:11>