[Django] #24730: Egg loader should catch more specific exception

10 views
Skip to first unread message

Django

unread,
Apr 30, 2015, 10:49:18 AM4/30/15
to django-...@googlegroups.com
#24730: Egg loader should catch more specific exception
--------------------------------------+--------------------
Reporter: prestontimmons | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Template system | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
The `django.template.loaders.eggs.Loader` uses a bare try/except when
trying to load templates. It would be better to catch the specific
exception(s) raised by `resource_string` when a template does not exist
and let any others pass through.

This is similar to the change made in #24399 for the filesystem template
loaders.

--
Ticket URL: <https://code.djangoproject.com/ticket/24730>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 30, 2015, 12:09:56 PM4/30/15
to django-...@googlegroups.com
#24730: Egg loader should catch more specific exception
--------------------------------------+------------------------------------

Reporter: prestontimmons | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* version: 1.8 => master
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/24730#comment:1>

Django

unread,
Jul 16, 2015, 9:39:08 AM7/16/15
to django-...@googlegroups.com
#24730: Egg loader should catch more specific exception
--------------------------------------+------------------------------------
Reporter: prestontimmons | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: Template system | Version: master
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* status: new => closed
* resolution: => wontfix


Comment:

Egg loader is being deprecated in #25120.

--
Ticket URL: <https://code.djangoproject.com/ticket/24730#comment:2>

Reply all
Reply to author
Forward
0 new messages