Re: [Django] #35330: The update of related objects fails in the admin when the related model is camel case.

30 views
Skip to first unread message

Django

unread,
Mar 26, 2024, 5:01:31 PM3/26/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------+--------------------------------------
Reporter: devin13cox | Owner: devin13cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by devin13cox):

If I want to use the test models from the PR listed in the ticket, should
I just wait until that PR gets eventually merged in? Or is it preferred to
make any changes here independent of another ticket (and subsequently make
alterations to admin to work for this ticket)?
--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 26, 2024, 5:03:23 PM3/26/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------+--------------------------------------
Reporter: devin13cox | Owner: devin13cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by devin13cox):

Replying to [comment:2 devin13cox]:
> If I want to use the test models from the PR listed in the ticket,
should I just wait until that PR gets eventually merged in? Or is it
preferred to make any changes here independent of another ticket (and
subsequently make alterations to admin to work for this ticket)?

Or if there is another preferred way to approach this given the close
relationship between this ticket, the one mentioned in the description,
and #35331, I am open to suggestions!
--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:3>

Django

unread,
Mar 27, 2024, 11:48:42 AM3/27/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------+--------------------------------------
Reporter: devin13cox | Owner: devin13cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by Natalia Bidart):

Replying to [comment:3 devin13cox]:
> Replying to [comment:2 devin13cox]:
> > If I want to use the test models from the PR listed in the ticket,
should I just wait until that PR gets eventually merged in? Or is it
preferred to make any changes here independent of another ticket (and
subsequently make alterations to admin to work for this ticket)?
>
> Or if there is another preferred way to approach this given the close
relationship between this ticket, the one mentioned in the description,
and #35331, I am open to suggestions!

Hi! My suggestion would be to progress with this ticket independently of
the other tickets. Have you checked if any of the existing models would
help building your testcase?
--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:4>

Django

unread,
Mar 27, 2024, 2:10:54 PM3/27/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------+--------------------------------------
Reporter: devin13cox | Owner: devin13cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by devin13cox):

Replying to [comment:4 Natalia Bidart]:
> Replying to [comment:3 devin13cox]:
> > Replying to [comment:2 devin13cox]:
> > > If I want to use the test models from the PR listed in the ticket,
should I just wait until that PR gets eventually merged in? Or is it
preferred to make any changes here independent of another ticket (and
subsequently make alterations to admin to work for this ticket)?
> >
> > Or if there is another preferred way to approach this given the close
relationship between this ticket, the one mentioned in the description,
and #35331, I am open to suggestions!
>
> Hi! My suggestion would be to progress with this ticket independently of
the other tickets. Have you checked if any of the existing models would
help building your testcase?

I think the models `Pizza` and `Topping` are usable for Ticket #35331, but
I would need to alter `Topping` to use camel casing for this one. Or add
another filter horizontal admin, but at that point may be easier to make
independent additions.
--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:5>

Django

unread,
Mar 27, 2024, 2:48:28 PM3/27/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------+--------------------------------------
Reporter: devin13cox | Owner: devin13cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by devin13cox):

* has_patch: 0 => 1

Comment:

https://github.com/django/django/pull/18025
--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:6>

Django

unread,
Apr 2, 2024, 4:38:32 PM4/2/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------------+-------------------------------------
Reporter: devin13cox | Owner:
| devin13cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:7>

Django

unread,
Apr 2, 2024, 9:00:38 PM4/2/24
to django-...@googlegroups.com
#35330: The update of related objects fails in the admin when the related model is
camel case.
-------------------------------------+-------------------------------------
Reporter: devin13cox | Owner:
| devin13cox
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"8665cf03d79c4b6222514c5943ccf3863a19cf08" 8665cf03]:
{{{#!CommitTicketReference repository=""
revision="8665cf03d79c4b6222514c5943ccf3863a19cf08"
Fixed #35330 -- Fixed the update of related widgets when the referenced
model is camel case named.

Co-authored-by: Natalia <124304+...@users.noreply.github.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35330#comment:8>
Reply all
Reply to author
Forward
0 new messages