Re: [Django] #35371: False positive in JS module aggregation export regex when an export declaration precedes an import declaration

[Django]

#35371: False positive in JS module aggregation export regex when an export
declaration precedes an import declaration
-------------------------------------+-------------------------------------
Reporter: Michael | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Calvin Vu):

* cc: Calvin Vu (added)
* owner: nobody => Calvin Vu
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35371#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35371: False positive in JS module aggregation export regex when an export
declaration precedes an import declaration
-------------------------------------+-------------------------------------
Reporter: Michael | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Calvin Vu):

An observation: the extra line you add at the beginning of {{{module.js}}}
doesn't even have to be a proper export, if you add even {{{//export}}}
before the imports then it raises the same ValueError
--
Ticket URL: <https://code.djangoproject.com/ticket/35371#comment:5>

[Django]

#35371: False positive in JS module aggregation export regex when an export
declaration precedes an import declaration
-------------------------------------+-------------------------------------
Reporter: Michael | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Calvin Vu):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35371#comment:6>

[Django]

#35371: False positive in JS module aggregation export regex when an export
declaration precedes an import declaration
-------------------------------------+-------------------------------------
Reporter: Michael | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35371#comment:7>

[Django]

#35371: False positive in JS module aggregation export regex when an export
declaration precedes an import declaration
-------------------------------------+-------------------------------------
Reporter: Michael | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by blighj):

This package I've been working on and hoping to get feedback on, takes
care of this ticket as it is no longer using regex's to parse
import/export statements ​https://github.com/blighj/django-
manifeststaticfiles-enhanced
--
Ticket URL: <https://code.djangoproject.com/ticket/35371#comment:8>

[Django]

#35371: False positive in JS module aggregation export regex when an export
declaration precedes an import declaration
-------------------------------------+------------------------------------

Reporter: Michael | Owner: blighj

Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------

Changes (by blighj):

* owner: Calvin Vu => blighj

Comment:

https://github.com/django/django/pull/19561 Will solve this ticket too.
This ticket can be closed if that is approved
--
Ticket URL: <https://code.djangoproject.com/ticket/35371#comment:9>