[Django] #27728: Allow overriding admin templatetag's templates.
Django
--------------------------------------------+------------------------
Reporter: Raffaele Salmaso | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
Refs
https://code.djangoproject.com/ticket/11974
https://code.djangoproject.com/ticket/12566
https://code.djangoproject.com/ticket/18957
https://code.djangoproject.com/ticket/19235
https://code.djangoproject.com/ticket/26763
It would be really nice that could be possible to override some
templatetag's templates using the "standard" admin patter of
`admin/app_label/model/template.html`.
actions.html
change_list_results.html
date_hierarchy.html
pagination.html
search_form.html
submit_line.html
and the object_tools blocks which now are hardcoded in change_form.html
and change_list.html
--
Ticket URL: <https://code.djangoproject.com/ticket/27728>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Raffaele Salmaso | Owner: nobody
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* has_patch: 1 => 0
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
Old description:
> Refs
> https://code.djangoproject.com/ticket/11974
> https://code.djangoproject.com/ticket/12566
> https://code.djangoproject.com/ticket/18957
> https://code.djangoproject.com/ticket/19235
> https://code.djangoproject.com/ticket/26763
>
> It would be really nice that could be possible to override some
> templatetag's templates using the "standard" admin patter of
> `admin/app_label/model/template.html`.
>
> actions.html
> change_list_results.html
> date_hierarchy.html
> pagination.html
> search_form.html
> submit_line.html
>
> and the object_tools blocks which now are hardcoded in change_form.html
> and change_list.html
New description:
Refs #11974, #12566, #18957, #19235, #26763
It would be really nice that could be possible to override some
templatetag's templates using the "standard" admin patter of
`admin/app_label/model/template.html`.
actions.html
change_list_results.html
date_hierarchy.html
pagination.html
search_form.html
submit_line.html
and the object_tools blocks which now are hardcoded in change_form.html
and change_list.html
--
Comment:
It's probably okay. I would start small rather than updating all the tags
at once.
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Raffaele Salmaso):
* status: new => assigned
* owner: nobody => Raffaele Salmaso
* has_patch: 0 => 1
* version: 1.10 => master
Comment:
Cleaned up PR => https://github.com/django/django/pull/7840
I made one commit for base templatetag and one commit for each converted
templatetag.
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Collin Anderson):
* cc: Collin Anderson (added)
* stage: Accepted => Ready for checkin
Comment:
lgtm
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson <carlton.gibson@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"5cc28dc752c3ae78456bb835c3ba195489fc26d7" 5cc28dc7]:
{{{
#!CommitTicketReference repository=""
revision="5cc28dc752c3ae78456bb835c3ba195489fc26d7"
Fixed #27728 -- Allowed overriding admin templatetags templates.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
PR merged in
[https://github.com/django/django/commit/5cc28dc752c3ae78456bb835c3ba195489fc26d7
5cc28dc]
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"4c02e3cda364a8455872a9ec9b3417c10a5c66b7" 4c02e3cd]:
{{{
#!CommitTicketReference repository=""
revision="4c02e3cda364a8455872a9ec9b3417c10a5c66b7"
Refs #27728 -- Made cosmetic edits to admin template tag template
overriding.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"94a180402c9e52bca2e911b6427c88f436e95449" 94a1804]:
{{{
#!CommitTicketReference repository=""
revision="94a180402c9e52bca2e911b6427c88f436e95449"
Refs #27728 -- Fixed thread safety of admin template tags.
Regression in 5cc28dc752c3ae78456bb835c3ba195489fc26d7.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"167d98528a2f38e370507ffe4f352b3406f5c5e1" 167d9852]:
{{{
#!CommitTicketReference repository=""
revision="167d98528a2f38e370507ffe4f352b3406f5c5e1"
Refs #27728 -- Fixed BytesWarning in admin_views tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27728#comment:7>