[Django] #24966: Unconfigured Allowed_Hosts Setting Should Raise ImproperlyConfigured Error
Django
--------------------------------------+---------------------
Reporter: raiderrobert | Owner:
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 1.8
Severity: Normal | Keywords: setting
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+---------------------
Allowed_Hosts is a required setting. When debug mode is off, and
Allowed_Hosts is not implemented, this should raise an
ImproperlyConfigured Error.
See conversation here: https://groups.google.com/forum/#!topic/django-
developers/nIrbGjyOsNY
--
Ticket URL: <https://code.djangoproject.com/ticket/24966>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Cleanup/optimization | Status: assigned
Component: Uncategorized | Version: 1.8
Severity: Normal | Resolution:
Keywords: setting | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by raiderrobert):
* owner: => raiderrobert
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:1>
Django
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: setting | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by carljm):
* component: Uncategorized => Core (Other)
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:2>
Django
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.8
Severity: Normal | Resolution:
Keywords: setting | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by raiderrobert):
Going to make it a warning instead of a hard fail. It's going in
`core/checks/security/base.py`.
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:3>
Django
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.8
Severity: Normal | Resolution:
Keywords: setting | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_docs: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:4>
Django
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.8
Severity: Normal | Resolution:
Keywords: setting | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Comment (by sggottlieb):
Submitted a pull request to raiderrobert that adds documentation for his
pull request.
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.8
Severity: Normal | Resolution:
Keywords: setting | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_docs: 1 => 0
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: raiderrobert | Owner:
Type: | raiderrobert
Component: Core (Other) | Version: 1.8
Keywords: setting | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ed514caed20995814712fd6c9e9c4120b4ac64be" ed514cae]:
{{{
#!CommitTicketReference repository=""
revision="ed514caed20995814712fd6c9e9c4120b4ac64be"
Fixed #24966 -- Added deployment system check for empty ALLOWED_HOSTS.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24966#comment:7>