Re: [Django] #11698: Add Django Debug Toolbar to contrib
Django
-----------------------------------------+------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Someday/Maybe | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------------
Changes (by gumuz):
* ui_ux: => 0
* easy: => 0
Comment:
After discussing this with Jannis, here are some ideas of how something
like this might work:
Instead of having middleware appending html content to the response like
it does now, debug data can be stored server-side so it can be requested
on demand using javascript for example.
Storing this data might be done using the existing logger infrastructure.
This basically turns the whole debug toolbar into a live log viewer, but
with the addition of structured/serialized debug data embedded into the
log messages, which makes it possible to present this data in a useful
way. Some care has to be taken to ensure the the data is only from the
viewers session and that individual requests can be identified.
The advantages of this approach are that the data is not inserted as html
anymore and is not restricted to just the current request. This way for
example also enable ajax request/response inspection.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-----------------------------------------+------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Someday/Maybe | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------------
Comment (by acdha):
The Chrome SpeedTracer (http://code.google.com/webtoolkit/speedtracer/)
API does something similar: the server simply provides a header containing
a URL to retrieve trace data for instrumented clients. I implemented this
in https://github.com/acdha/django-speedtracer simply by storing the
report data in the cache using a UUID for each request. This approach
worked really well both for performance - no problems like debug-toolbar
has generating huge HTML stack traces for a page which accidentally does
too many queries - and it's easy to have this pulled out using XHR or
even, assuming some sort of user-keyed storage, retrieved from another
machine in context such as mobile development where the client doesn't
have your diagnostic tools.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:8>
Django
-----------------------------------------+------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Someday/Maybe | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------------
* cc: ShawnMilo (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:9>
Django
---------------------------------------+------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
Changes (by jezdez):
* stage: Someday/Maybe => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:11>
Django
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
Comment (by jezdez):
@acdha Wow, that looks really good, +1 on using that approach. Combined
with DDT's panels for data collection this would be great.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:10>
Django
---------------------------------------+------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
Comment (by jezdez):
FTR, there was some work done to revamp the way the toolbar injects itself
in the page at https://github.com/Maykin/django-debug-
toolbar/commits/master
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:12>
Django
---------------------------------------+------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Contrib apps
Version: 1.1 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------------
* cc: djangoproject.com@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:13>
Django
Reporter: russellm | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by loic84):
Is there still a long term goal of adding DDT to django.contrib?
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:14>
Django
------------------------------+------------------------------------
Reporter: russellm | Owner: nobody
Component: Contrib apps | Version: 1.1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
* status: new => closed
* resolution: => wontfix
Comment:
Marking as wontfix since we're increasingly removing apps from contrib and
are promoting standard Python packaging tools instead. FTR, I'm a
committer to the debug toolbar and would happily encourage feedback about
it.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:15>
Django
------------------------------+------------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: closed
Component: Contrib apps | Version: 1.1
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Comment (by aaugustin):
jezdez, do you think we should point to the DDT in the tutorial?
It's probably the most widely used addon for Django after the admin.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:16>
Django
------------------------------+------------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: closed
Component: Contrib apps | Version: 1.1
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Comment (by mjtamlyn):
This comes back to the whole concept of recommended external packages in
the docs. I'm +0 on the idea, but it's not a discussion for this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:17>
Django
------------------------------+------------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: closed
Component: Contrib apps | Version: 1.1
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Comment (by jezdez):
aaugustin, sure why not -- as soon as DDT has a Django > 1.5 and Python 3
compatible release out.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:18>
Django
------------------------------+------------------------------------
Reporter: russellm | Owner: nobody
Type: New feature | Status: closed
Component: Contrib apps | Version: 1.1
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Comment (by aaugustin):
DDT 1.0 was released with support for Django 1.4+ and Python 2.6+/3.2+.
--
Ticket URL: <https://code.djangoproject.com/ticket/11698#comment:19>