[Django] #33334: TypedChoiceField misplaced in form fields docs

12 views
Skip to first unread message

Django

unread,
Nov 30, 2021, 3:45:29 PM11/30/21
to django-...@googlegroups.com
#33334: TypedChoiceField misplaced in form fields docs
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
Form fields are alphabetically sorted in the
[https://docs.djangoproject.com/en/dev/ref/forms/fields/ reference for
form fields], except for TypedChoiceField.

--
Ticket URL: <https://code.djangoproject.com/ticket/33334>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 30, 2021, 4:04:25 PM11/30/21
to django-...@googlegroups.com
#33334: TypedChoiceField misplaced in form fields docs
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

There are some others out of order. Similar to TypedChoiceField following
ChoieField, TypedMultipleChoiceField follows MultipleChoiceField. Also
GenericIPAddressField is out of order. It probably followed IPAddressField
before its removal.

--
Ticket URL: <https://code.djangoproject.com/ticket/33334#comment:1>

Django

unread,
Dec 1, 2021, 2:21:06 AM12/1/21
to django-...@googlegroups.com
#33334: Alphabetize form and model fields in docs.
--------------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

In models fields only `GenericIPAddressField` is unsorted, I think we
should also alphabetize it.

--
Ticket URL: <https://code.djangoproject.com/ticket/33334#comment:2>

Django

unread,
Dec 2, 2021, 1:20:22 AM12/2/21
to django-...@googlegroups.com
#33334: Alphabetize form and model fields in docs.
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Shivam
Type: | Durgbuns
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Shivam Durgbuns):

* owner: nobody => Shivam Durgbuns
* status: new => assigned


Comment:

Will be fixing the document for :


There are some others out of order. Similar to TypedChoiceField following
ChoieField, TypedMultipleChoiceField follows MultipleChoiceField. Also
GenericIPAddressField is out of order. It probably followed IPAddressField
before its removal.

--
Ticket URL: <https://code.djangoproject.com/ticket/33334#comment:3>

Django

unread,
Dec 2, 2021, 2:35:00 AM12/2/21
to django-...@googlegroups.com
#33334: Alphabetize form and model fields in docs.
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Shivam
Type: | Durgbuns
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


Comment:

[https://github.com/django/django/pull/15145 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33334#comment:4>

Django

unread,
Dec 2, 2021, 4:12:42 AM12/2/21
to django-...@googlegroups.com
#33334: Alphabetize form and model fields in docs.
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Shivam
Type: | Durgbuns
Cleanup/optimization | Status: closed
Component: Documentation | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"d75c387f46c55459a2daf071e5463bad0ad7dcbd" d75c387f]:
{{{
#!CommitTicketReference repository=""
revision="d75c387f46c55459a2daf071e5463bad0ad7dcbd"
Fixed #33334 -- Alphabetized form and model fields in reference docs.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33334#comment:5>

Django

unread,
Dec 2, 2021, 4:13:01 AM12/2/21
to django-...@googlegroups.com
#33334: Alphabetize form and model fields in docs.
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Shivam
Type: | Durgbuns
Cleanup/optimization | Status: closed
Component: Documentation | Version: dev

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"306fbf197a742b4b79e4ed23c94f5bbdbec9afdc" 306fbf19]:
{{{
#!CommitTicketReference repository=""
revision="306fbf197a742b4b79e4ed23c94f5bbdbec9afdc"
[4.0.x] Fixed #33334 -- Alphabetized form and model fields in reference
docs.

Backport of d75c387f46c55459a2daf071e5463bad0ad7dcbd from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33334#comment:6>

Reply all
Reply to author
Forward
0 new messages