[Django] #33300: admin form hidden field css error.
Django
-------------------------------------+-------------------------------------
Reporter: Maxim | Owner: nobody
Danilov |
Type: Bug | Status: new
Component: | Version: 4.0
contrib.admin | Keywords: admin, modeladmin,
Severity: Normal | css
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
hidden admin field has wrapped div:
<div class="fieldBox field-value_char hidden">...</div>
it is should be hidden:
base.css, 302 row
.hidden {
display: none;
}
But not for small screen:
responsive.css, 559 row
@media (max-width: 767px)
.aligned .form-row, .aligned .form-row > div {
display: flex;
...
}
--
Ticket URL: <https://code.djangoproject.com/ticket/33300>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: xdqc
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: admin, modeladmin, | Triage Stage:
css | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => assigned
* owner: nobody => xdqc
* has_patch: 0 => 1
* ui_ux: 0 => 1
Old description:
> hidden admin field has wrapped div:
> <div class="fieldBox field-value_char hidden">...</div>
>
> it is should be hidden:
> base.css, 302 row
> .hidden {
> display: none;
> }
>
> But not for small screen:
> responsive.css, 559 row
> @media (max-width: 767px)
> .aligned .form-row, .aligned .form-row > div {
> display: flex;
> ...
> }
New description:
hidden admin field has wrapped div:
{{{
<div class="fieldBox field-value_char hidden">...</div>
}}}
it is should be hidden: `base.css`, 302 row
{{{
.hidden {
display: none;
}
}}}
But not for small screen: `responsive.css`, 559 row
{{{
@media (max-width: 767px)
.aligned .form-row, .aligned .form-row > div {
display: flex;
...
}
}}}
--
Comment:
Thanks for the report.
[https://github.com/django/django/pull/14775 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: xdqc
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
css |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: xdqc
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: admin, modeladmin, | Triage Stage: Accepted
css |
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:3>
Django
-------------------------------------+-------------------------------------
| Parmar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: admin, modeladmin, | Triage Stage: Accepted
css |
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Shubh Parmar):
* owner: xdqc => Shubh Parmar
Comment:
I will add the required test for this patch
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Shubh
| Parmar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: admin, modeladmin, | Triage Stage: Accepted
css |
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Shubh Parmar):
PR [https://github.com/django/django/pull/15255]
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Shubh
| Parmar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
css | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Shubh
| Parmar
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: admin, modeladmin, | Triage Stage: Ready for
css | checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"aecfc40c88ce19aa0b830ee2d3d2077b304757bc" aecfc40c]:
{{{
#!CommitTicketReference repository=""
revision="aecfc40c88ce19aa0b830ee2d3d2077b304757bc"
Fixed #33300 -- Ensured hidden elements are not displayed on small
screens.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33300#comment:7>