Re: [Django] #13376: Messages should have an "expire" flag

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+------------------------------------
Reporter: ryanshow@… | Owner:
Type: New feature | Status: new
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by marekw2143):

* status: assigned => new
* owner: marekw2143 =>
* ui_ux: => 0
* easy: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#13376: Messages should have an "expire" flag

----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned

Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0

----------------------------------+---------------------------------------
Changes (by Andy Miller):

* owner: (none) => Andy Miller
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:9>

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------

Changes (by Ryan Cheley):

* cc: Ryan Cheley (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:10>

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------

Comment (by Andy Miller):

Draft PR: [https://github.com/django/django/pull/18286]

I need to review the current code and the patch file as some did not apply
at all (mostly in tests since they have moved in the last 13 years)
Docs need to be added (I need to research this and consider what needs to
be added)

Then I think some feedback would be useful to know if the previous authors
were on the right track and what more needs to be done.
--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:11>

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Comment (by Andy Miller):

I have decided to split this ticket into 2 PRs as per the discussion I
started on the forum here: https://forum.djangoproject.com/t/ticket-13376
-messages-should-have-an-expire-flag/32190


The first of the 2 PRs is here:
https://github.com/django/django/pull/18332 which modifies the python API
which would allow this ticket/patch to then be implemented as a third-
party package with minimal changes.
--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:12>

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------

Changes (by Andy Miller):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:13>

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by Andy Miller):

* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:14>

[Django]

#13376: Messages should have an "expire" flag
----------------------------------+---------------------------------------
Reporter: ryanshow@… | Owner: Andy Miller
Type: New feature | Status: assigned
Component: contrib.messages | Version: 1.2-beta
Severity: Normal | Resolution:
Keywords: messages, expire | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13376#comment:15>