[Django] #28730: Large integer literals lose precision in templates

6 views
Skip to first unread message

Django

unread,
Oct 20, 2017, 12:46:09 PM10/20/17
to django-...@googlegroups.com
#28730: Large integer literals lose precision in templates
-------------------------------------------+------------------------
Reporter: Fraser Nevett | Owner: nobody
Type: Uncategorized | Status: new
Component: Template system | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
While looking at #28721, I realised that there is loss of precision on
large integer literals:

{{{
#!python
>>> from django.template import Template, Context
>>> Template('{{ 999999999999999999999999999 }}').render(Context())
u'1000000000000000013287555072'
}}}

This happens because the code tries to first convert literal values to a
**float** and then from the **float** to an **int**, which is a lossy
operation.

--
Ticket URL: <https://code.djangoproject.com/ticket/28730>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 20, 2017, 12:48:44 PM10/20/17
to django-...@googlegroups.com
#28730: Large integer literals lose precision in templates
---------------------------------+--------------------------------------

Reporter: Fraser Nevett | Owner: nobody
Type: Bug | Status: new

Component: Template system | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Fraser Nevett):

* type: Uncategorized => Bug


--
Ticket URL: <https://code.djangoproject.com/ticket/28730#comment:1>

Django

unread,
Oct 20, 2017, 12:50:08 PM10/20/17
to django-...@googlegroups.com
#28730: Large integer literals lose precision in templates
---------------------------------+------------------------------------

Reporter: Fraser Nevett | Owner: nobody
Type: Bug | Status: new

Component: Template system | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28730#comment:2>

Django

unread,
Oct 21, 2017, 6:28:38 AM10/21/17
to django-...@googlegroups.com
#28730: Large integer literals lose precision in templates
---------------------------------+------------------------------------

Reporter: Fraser Nevett | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1
* version: 1.11 => master


Comment:

[https://github.com/django/django/pull/9267 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28730#comment:3>

Django

unread,
Oct 21, 2017, 9:43:28 AM10/21/17
to django-...@googlegroups.com
#28730: Large integer literals lose precision in templates
-------------------------------------+-------------------------------------

Reporter: Fraser Nevett | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28730#comment:4>

Django

unread,
Oct 21, 2017, 11:21:36 AM10/21/17
to django-...@googlegroups.com
#28730: Large integer literals lose precision in templates
-------------------------------------+-------------------------------------

Reporter: Fraser Nevett | Owner: nobody
Type: Bug | Status: closed

Component: Template system | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"9ec7d8e514e09636b0ab4bcac74b5f7a5be335a3" 9ec7d8e]:
{{{
#!CommitTicketReference repository=""
revision="9ec7d8e514e09636b0ab4bcac74b5f7a5be335a3"
Fixed #28730 -- Fixed loss of precision for large integer literals in
templates

Thanks Fraser Nevett for the report and Tim Graham for patch edits.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28730#comment:5>

Reply all
Reply to author
Forward
0 new messages