[Django] #33131: Improve Reverse Accessor Clash feedback

17 views
Skip to first unread message

Django

unread,
Sep 22, 2021, 6:26:15 AM9/22/21
to django-...@googlegroups.com
#33131: Improve Reverse Accessor Clash feedback
-----------------------------------------+------------------------
Reporter: Bernd Wechner | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
refer: https://github.com/django/django/pull/14880

RelatedField._check_clashes() provides feedback when it finds a clash, but
fails to mentioned what the clashing name was. This cost me some
significant time to track because of inadequate feedback and would have
become immediately clear had the feedback listed the clashing name.

A proposed patch appears above, but alas this impacts some unit tests as
well. Happy to add fixes to those to the patch, but have been requested to
file and issue here.

--
Ticket URL: <https://code.djangoproject.com/ticket/33131>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 28, 2021, 1:17:44 AM9/28/21
to django-...@googlegroups.com
#33131: Improve error messages for reverse accessor clashes.
-------------------------------------+-------------------------------------
Reporter: Bernd Wechner | Owner: Bernd
Type: | Wechner
Cleanup/optimization | Status: assigned
Component: Core (System | Version: 3.2
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => assigned
* needs_better_patch: 0 => 1
* component: Uncategorized => Core (System checks)
* owner: nobody => Bernd Wechner
* needs_docs: 0 => 1
* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

Thanks for the ticket. We should also update the message for
`fields.E302`.

[https://github.com/django/django/pull/14880 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33131#comment:1>

Django

unread,
Oct 6, 2021, 6:26:22 AM10/6/21
to django-...@googlegroups.com
#33131: Improve error messages for reverse accessor clashes.
-------------------------------------+-------------------------------------
Reporter: Bernd Wechner | Owner: Bernd
Type: | Wechner
Cleanup/optimization | Status: assigned
Component: Core (System | Version: 3.2
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/33131#comment:2>

Django

unread,
Oct 6, 2021, 2:26:39 PM10/6/21
to django-...@googlegroups.com
#33131: Improve error messages for reverse accessor clashes.
-------------------------------------+-------------------------------------
Reporter: Bernd Wechner | Owner: Bernd
Type: | Wechner
Cleanup/optimization | Status: closed

Component: Core (System | Version: 3.2
checks) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"2116238d5f2ce19571becb5620ef16ce9048db9f" 2116238]:
{{{
#!CommitTicketReference repository=""
revision="2116238d5f2ce19571becb5620ef16ce9048db9f"
Fixed #33131 -- Improved error messages for clashing reverse accessor
names.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33131#comment:3>

Reply all
Reply to author
Forward
0 new messages