[Django] #31521: test_parsing_rfc850 fails on 32bit intel platforms
Django
---------------------------------------------+------------------------
Reporter: scarabeusiv | Owner: nobody
Type: Uncategorized | Status: new
Component: Testing framework | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
As the test checks for date that is not supported there it simply
overflows:
{{{
#!python
[ 405s] ERROR: test_parsing_rfc850
(utils_tests.test_http.HttpDateProcessingTests) [<object object at
0xa4e44cb0>] (rfc850str='Tuesday, 31-Dec-69 08:49:37 GMT')
[ 405s]
----------------------------------------------------------------------
[ 405s] Traceback (most recent call last):
[ 405s] File "/usr/lib/python3.8/unittest/case.py", line 60, in
testPartExecutor
[ 405s] yield
[ 405s] File "/usr/lib/python3.8/unittest/case.py", line 582, in
subTest
[ 405s] yield
[ 405s] File
"/home/abuild/rpmbuild/BUILD/Django-3.0.5/tests/utils_tests/test_http.py",
line 340, in test_parsing_rfc850
[ 405s] self.assertEqual(datetime.utcfromtimestamp(parsed),
expected_date)
[ 405s] OverflowError: timestamp out of range for platform time_t
[ 405s]
[ 405s]
======================================================================
[ 405s] ERROR: test_parsing_rfc850
(utils_tests.test_http.HttpDateProcessingTests) [<object object at
0xa4e44cb0>] (rfc850str='Wednesday, 31-Dec-70 08:49:37 GMT')
[ 405s]
----------------------------------------------------------------------
[ 405s] Traceback (most recent call last):
[ 405s] File "/usr/lib/python3.8/unittest/case.py", line 60, in
testPartExecutor
[ 405s] yield
[ 405s] File "/usr/lib/python3.8/unittest/case.py", line 582, in
subTest
[ 405s] yield
[ 405s] File
"/home/abuild/rpmbuild/BUILD/Django-3.0.5/tests/utils_tests/test_http.py",
line 340, in test_parsing_rfc850
[ 405s] self.assertEqual(datetime.utcfromtimestamp(parsed),
expected_date)
[ 405s] OverflowError: timestamp out of range for platform time_t
[ 405s]
[ 405s]
----------------------------------------------------------------------
}}}
I guess easiest is to skip those on if the platform is known to not
support it.
--
Ticket URL: <https://code.djangoproject.com/ticket/31521>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: scarabeusiv | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by felixxm):
* component: Testing framework => Core (Other)
* version: 3.0 => master
* easy: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Thanks, it's fixable (see similar ticket #30264). We can use dates from
the previous century.
--
Ticket URL: <https://code.djangoproject.com/ticket/31521#comment:1>
Django
Reporter: Tomáš Chvátal | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):
* owner: nobody => Hasan Ramezani
* status: new => assigned
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31521#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Tomáš Chvátal | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31521#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Tomáš Chvátal | Owner: Hasan
Type: | Ramezani
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f12162107327b88a2f1faaab15d048e2535ec642" f1216210]:
{{{
#!CommitTicketReference repository=""
revision="f12162107327b88a2f1faaab15d048e2535ec642"
Fixed #31521 -- Skipped test_parsing_rfc850 test on 32-bit systems.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31521#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Tomáš Chvátal | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"8e23b89ffd103d127b0cf6db9d7e9d75a8e50452" 8e23b89f]:
{{{
#!CommitTicketReference repository=""
revision="8e23b89ffd103d127b0cf6db9d7e9d75a8e50452"
[3.0.x] Fixed #31521 -- Skipped test_parsing_rfc850 test on 32-bit
systems.
Backport of f12162107327b88a2f1faaab15d048e2535ec642 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31521#comment:5>