[Django] #33446: ManifestStaticFilesStorage doesn't update CSS source map references

2 views
Skip to first unread message

Django

unread,
Jan 18, 2022, 4:03:49 AMJan 18
to django-...@googlegroups.com
#33446: ManifestStaticFilesStorage doesn't update CSS source map references
-----------------------------------------------+------------------------
Reporter: Adam Johnson | Owner: nobody
Type: New feature | Status: new
Component: contrib.staticfiles | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------------+------------------------
A follow-up to #32383, which added JS source map support.

The [https://sourcemaps.info/spec.html source map spec] also covers CSS
source maps. I think Django should update these references too for the
same reasons as JS source maps.

--
Ticket URL: <https://code.djangoproject.com/ticket/33446>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 18, 2022, 4:12:09 AMJan 18
to django-...@googlegroups.com
#33446: ManifestStaticFilesStorage doesn't update CSS source map references
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Adam Johnson
* status: new => assigned
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/33446#comment:1>

Django

unread,
Jan 18, 2022, 6:54:54 AMJan 18
to django-...@googlegroups.com
#33446: ManifestStaticFilesStorage doesn't update CSS source map references
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


Comment:

[https://github.com/django/django/pull/15329 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33446#comment:2>

Django

unread,
Jan 18, 2022, 9:09:24 AMJan 18
to django-...@googlegroups.com
#33446: ManifestStaticFilesStorage doesn't update CSS source map references
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: closed
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"dc8bb35e39388d41b1f38b6c5d0181224e075f16" dc8bb35]:
{{{
#!CommitTicketReference repository=""
revision="dc8bb35e39388d41b1f38b6c5d0181224e075f16"
Fixed #33446 -- Added CSS source map support to
ManifestStaticFilesStorage.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33446#comment:3>

Django

unread,
Mar 5, 2022, 6:22:15 AMMar 5
to django-...@googlegroups.com
#33446: ManifestStaticFilesStorage doesn't update CSS source map references
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: closed
Component: contrib.staticfiles | Version: dev

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"b811364421c8eea0cf06459462cf1fd58184773b" b8113644]:
{{{
#!CommitTicketReference repository=""
revision="b811364421c8eea0cf06459462cf1fd58184773b"
Refs #33446 -- Allowed variable whitespace in CSS source map references.

Follow up to dc8bb35e39388d41b1f38b6c5d0181224e075f16.

The Webpack default is to output CSS source map comments like
`/*# sourceMappingURL=main.css.map*/`. Also, Chromium allows tabs.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33446#comment:4>

Reply all
Reply to author
Forward
0 new messages