[Django] #21992: test_naturalday_uses_localtime fails on Windows
Django
----------------------------------+--------------------
Reporter: anonymous | Owner: nobody
Type: Bug | Status: new
Component: contrib.humanize | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------
`django.contrib.humanize.tests.test_naturalday_uses_localtime` is
decorated by a `skipIf` clause as per #19203.
However, running on a Windows machine -- with `pytz` not installed and
system timezone set to UTC -- the skip condition still evaluates to
`False`. This is since `settings.TIME_ZONE` does default to
`"America/Chicago"`, and, as a result, the test case fails.
--
Ticket URL: <https://code.djangoproject.com/ticket/21992>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: anonymous | Owner: nobody
Type: Bug | Status: new
Component: contrib.humanize | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mjtamlyn):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/21992#comment:1>
Django
Reporter: anonymous | Owner: nobody
Type: Bug | Status: new
Component: contrib.humanize | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by anonymous):
Relevant pull request: https://github.com/django/django/pull/2250
--
Ticket URL: <https://code.djangoproject.com/ticket/21992#comment:2>
Django
Reporter: anonymous | Owner: nobody
Type: Bug | Status: new
Component: contrib.humanize | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* needs_better_patch: 0 => 1
Comment:
I think @require_tz_support is the answer here. The test attempt to change
the time zone and Windows cannot do that.
--
Ticket URL: <https://code.djangoproject.com/ticket/21992#comment:3>
Django
Reporter: anonymous | Owner: nobody
Type: Bug | Status: closed
Component: contrib.humanize | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* status: new => closed
* resolution: => fixed
Comment:
It looks like this was fixed in 651a6f76f30f4083dfa2a75c5acd86359c2fc4a2.
--
Ticket URL: <https://code.djangoproject.com/ticket/21992#comment:4>