[Django] #35700: Reduce CreateModel + AlterModelTable to CreateModel

33 views
Skip to first unread message

Django

unread,
Aug 22, 2024, 6:57:42 AM8/22/24
to django-...@googlegroups.com
#35700: Reduce CreateModel + AlterModelTable to CreateModel
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Type:
| Cleanup/optimization
Status: new | Component:
| Migrations
Version: dev | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Like #33572, migration optimization can reduce `CreateModel` and
`AlterModelTable` for the same model down to just `CreateModel` with
`db_table` in `options`.
--
Ticket URL: <https://code.djangoproject.com/ticket/35700>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 22, 2024, 1:20:28 PM8/22/24
to django-...@googlegroups.com
#35700: Reduce CreateModel + AlterModelTable to CreateModel
--------------------------------------+------------------------------------
Reporter: Adam Johnson | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Simon Charette):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35700#comment:1>

Django

unread,
Aug 22, 2024, 2:23:20 PM8/22/24
to django-...@googlegroups.com
#35700: Reduce CreateModel + AlterModelTable to CreateModel
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: Migrations | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* owner: (none) => Adam Johnson
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35700#comment:2>

Django

unread,
Aug 26, 2024, 7:36:03 AM8/26/24
to django-...@googlegroups.com
#35700: Reduce CreateModel + AlterModelTable to CreateModel
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: Migrations | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* stage: Accepted => Ready for checkin

Comment:

Two approvals on GitHub so I'm taking the initiative and marking as ready
for checkin.
--
Ticket URL: <https://code.djangoproject.com/ticket/35700#comment:3>

Django

unread,
Aug 30, 2024, 12:50:21 PM8/30/24
to django-...@googlegroups.com
#35700: Reduce CreateModel + AlterModelTable to CreateModel
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: closed
Component: Migrations | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"20d44abb41b3dde7f7edc556b784aef48c5ceddf" 20d44abb]:
{{{#!CommitTicketReference repository=""
revision="20d44abb41b3dde7f7edc556b784aef48c5ceddf"
Fixed #35700 -- Added AlterModelTable and AlterModelTableComment
reductions.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35700#comment:4>
Reply all
Reply to author
Forward
0 new messages