Re: [Django] #35373: GeneratedField alteration fail on SQLite due table remake data insertion

16 views
Skip to first unread message

Django

unread,
Apr 16, 2024, 10:30:10 AM4/16/24
to django-...@googlegroups.com
#35373: GeneratedField alteration fail on SQLite due table remake data insertion
-------------------------------------+-------------------------------------
Reporter: Moshe Dicker | Owner: Simon
| Charette
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: migrations,db | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* has_patch: 0 => 1
* owner: nobody => Simon Charette
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35373#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 16, 2024, 10:56:15 AM4/16/24
to django-...@googlegroups.com
#35373: GeneratedField alteration fail on SQLite due table remake data insertion
-------------------------------------+-------------------------------------
Reporter: Moshe Dicker | Owner: Simon
| Charette
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: migrations,db | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35373#comment:3>

Django

unread,
Apr 16, 2024, 11:27:48 AM4/16/24
to django-...@googlegroups.com
#35373: GeneratedField alteration fail on SQLite due table remake data insertion
-------------------------------------+-------------------------------------
Reporter: Moshe Dicker | Owner: Simon
| Charette
Type: Bug | Status: closed
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: migrations,db | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"d048f0d311cc9cb9578d687968f2d24a0a9efddb" d048f0d]:
{{{#!CommitTicketReference repository=""
revision="d048f0d311cc9cb9578d687968f2d24a0a9efddb"
Fixed #35373 -- Fixed a crash when indexing a generated field on SQLite.

Generated fields have to be excluded from the INSERT query against the
remade
table including the index.

Thanks Moshe Dicker for the report, David Sanders and Mariusz Felisiak for
the
review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35373#comment:4>

Django

unread,
Apr 16, 2024, 11:32:27 AM4/16/24
to django-...@googlegroups.com
#35373: GeneratedField alteration fail on SQLite due table remake data insertion
-------------------------------------+-------------------------------------
Reporter: Moshe Dicker | Owner: Simon
| Charette
Type: Bug | Status: closed
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: migrations,db | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"9d79714e25911dbc768ba4b71e5f838ee0688edc" 9d79714]:
{{{#!CommitTicketReference repository=""
revision="9d79714e25911dbc768ba4b71e5f838ee0688edc"
[5.0.x] Fixed #35373 -- Fixed a crash when indexing a generated field on
SQLite.

Generated fields have to be excluded from the INSERT query against the
remade
table including the index.

Thanks Moshe Dicker for the report, David Sanders and Mariusz Felisiak for
the
review.

Backport of d048f0d311cc9cb9578d687968f2d24a0a9efddb from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35373#comment:5>
Reply all
Reply to author
Forward
0 new messages