[Django] #25143: ArrayField should implement from_db_value()
Django
----------------------------------+-----------------
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+-----------------
I'm using a custom field with the new Postgres {{{ArrayField}}}:
{{{
class Tag(object):
def __init__(self, id):
self.id = id
def __unicode__(self):
return U"Tag(%d)" % self.id
class TagField(models.SmallIntegerField):
# Dummy wrapper over SmallIntegerField.
def from_db_value(self, value, expression, connection, context):
if value is None:
return value
return Tag(int(value))
def get_prep_value(self, value):
return value
...
# models.py
class Recommendation(models.Model):
tags = ArrayField(TagField(), size=3)
def __unicode__(self):
return self.tags
}}}
Then
{{{
>>> Recommendation.objects.create(tags=[Tag(1), Tag(2)])
>>> Recommendation.objects.all()
[<Recommendation: [1, 2]>] # WRONG
}}}
But this is wrong because I got Integers instead of Tag objects:
{{{
[<Recommendation: [Tag(1), Tag(2)]>] # OK
}}}
Looking at the {{{ArrayField}}} source code seems that {{{to_python()}}}
is implemented but never called. I think {{{from_db_value()}}} should be
also implemented.
--
Ticket URL: <https://code.djangoproject.com/ticket/25143>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Odahi):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> Then
>
New description:
I'm using a custom field with the new Postgres {{{ArrayField}}}:
{{{
class Tag(object):
def __init__(self, id):
self.id = id
def __unicode__(self):
return U"Tag(%d)" % self.id
class TagField(models.SmallIntegerField):
# Dummy wrapper over SmallIntegerField.
def from_db_value(self, value, expression, connection, context):
if value is None:
return value
return Tag(int(value))
def get_prep_value(self, value):
return value
...
# models.py
class Recommendation(models.Model):
tags = ArrayField(TagField(), size=3)
def __unicode__(self):
return self.tags
}}}
Then
{{{
>>> Recommendation.objects.create(tags=[Tag(1), Tag(2)])
>>> Recommendation.objects.all()
[<Recommendation: [1, 2]>] # WRONG
}}}
This is wrong because I got Integers instead of Tag objects:
{{{
[<Recommendation: [Tag(1), Tag(2)]>] # OK
}}}
Looking at the {{{ArrayField}}} source code seems that {{{to_python()}}}
is implemented but never called. I think {{{from_db_value()}}} should be
also implemented.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:1>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
Can you propose a patch and regression test?
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:2>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Odahi):
Replying to [comment:2 timgraham]:
> Can you propose a patch and regression test?
Hello Tim, never did it before, but I think I can submit a tentative patch
& test for this in the next days. I'll try.
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:3>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Odahi):
* has_patch: 0 => 1
Comment:
I've just added a tentative patch.
https://github.com/Odahi/django/tree/ticket_25143
Would be great if someone can check it.
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:4>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:5>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:6>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by timgraham):
See #25579 for a related issue (querying on complex types) that could be
fixed along with this.
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:7>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/6131 Updated PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:8>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:9>
Django
Reporter: Odahi | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:10>
Django
Reporter: Odahi | Owner: Tim
| Graham <timograham@…>
Type: Bug | Status: closed
Component: contrib.postgres | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* owner: => Tim Graham <timograham@…>
* resolution: => fixed
Comment:
In [changeset:"2495023a4cae28f494d0a6172abfac3a47a0b816" 2495023]:
{{{
#!CommitTicketReference repository=""
revision="2495023a4cae28f494d0a6172abfac3a47a0b816"
Fixed #25143 -- Added ArrayField.from_db_value().
Thanks Karan Lyons for contributing to the patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25143#comment:11>