[Django] #31468: Move migration name suggestion from AutoDetector to operation classes

18 views
Skip to first unread message

Django

unread,
Apr 15, 2020, 6:31:05 AM4/15/20
to django-...@googlegroups.com
#31468: Move migration name suggestion from AutoDetector to operation classes
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: nobody
(Chainz) Johnson |
Type: New | Status: assigned
feature |
Component: | Version: master
Migrations |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently migration automatic names are generated in one method in the
autodetector. This does not support all operation types, and has no way of
being extended for custom operation types. This logic should be moved to
the individual operations classes.

--
Ticket URL: <https://code.djangoproject.com/ticket/31468>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 15, 2020, 6:32:07 AM4/15/20
to django-...@googlegroups.com
#31468: Move migration name suggestion from AutoDetector to operation classes
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam (Chainz) Johnson):

[PR](https://github.com/django/django/pull/12131)

(I started this one just to add two methods and at Simon's suggestion, it
grew.)

--
Ticket URL: <https://code.djangoproject.com/ticket/31468#comment:1>

Django

unread,
Apr 15, 2020, 6:43:33 AM4/15/20
to django-...@googlegroups.com
#31468: Move migration name suggestion from AutoDetector to operation classes
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam (Chainz) Johnson):

* stage: Unreviewed => Accepted


Comment:

Marking as impicitly accepted by previous GitHub review.

--
Ticket URL: <https://code.djangoproject.com/ticket/31468#comment:2>

Django

unread,
May 28, 2020, 2:52:30 AM5/28/20
to django-...@googlegroups.com
#31468: Move migration name suggestion from AutoDetector to operation classes
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Adam
Johnson | (Chainz) Johnson

Type: New feature | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* owner: nobody => Adam (Chainz) Johnson
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31468#comment:3>

Django

unread,
May 28, 2020, 6:37:03 AM5/28/20
to django-...@googlegroups.com
#31468: Move migration name suggestion from AutoDetector to operation classes
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Adam
Johnson | (Chainz) Johnson
Type: New feature | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"5bd585a82dd963b3d8fdac2b37ff5276f71c5b27" 5bd585a]:
{{{
#!CommitTicketReference repository=""
revision="5bd585a82dd963b3d8fdac2b37ff5276f71c5b27"
Refs #31468 -- Added tests for MigrationAutodetector.suggest_name().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31468#comment:4>

Django

unread,
May 28, 2020, 6:37:04 AM5/28/20
to django-...@googlegroups.com
#31468: Move migration name suggestion from AutoDetector to operation classes
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Adam
Johnson | (Chainz) Johnson
Type: New feature | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"fa58450a9ab8a1bdd2a5090b51b00078fd85ffa6" fa58450]:
{{{
#!CommitTicketReference repository=""
revision="fa58450a9ab8a1bdd2a5090b51b00078fd85ffa6"
Fixed #31468 -- Allowed specifying migration filename in Operation.

This adds also suggested filename for many built-in operations.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31468#comment:5>

Reply all
Reply to author
Forward
0 new messages