Re: [Django] #35529: Have the template tag query_string support multiple arguments and arguments of type Mapping[str, Any]

30 views
Skip to first unread message

Django

unread,
Jun 19, 2024, 10:07:25 PM6/19/24
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
--------------------------------------+------------------------------------
Reporter: Sarah Boyce | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Template system | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted
* type: New feature => Cleanup/optimization

Comment:

Accepting following the forum conversation.
--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 28, 2024, 9:39:30 AM6/28/24
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
Type: | Terzopoulos
Cleanup/optimization | Status: assigned
Component: Template system | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Giannis Terzopoulos):

* owner: nobody => Giannis Terzopoulos
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:9>

Django

unread,
Jul 15, 2024, 9:32:35 AM7/15/24
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
Type: | Terzopoulos
Cleanup/optimization | Status: assigned
Component: Template system | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Giannis Terzopoulos):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/18368 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:10>

Django

unread,
Jul 30, 2024, 6:43:06 AM7/30/24
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
Type: | Terzopoulos
Cleanup/optimization | Status: assigned
Component: Template system | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:11>

Django

unread,
Aug 16, 2024, 2:14:25 PM8/16/24
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
Type: | Terzopoulos
Cleanup/optimization | Status: assigned
Component: Template system | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):

PR looks good but I found a few cases where it could be considered that we
are breaking previous behavior. I have proposed
[https://github.com/django/django/pull/18487 PR 18487] to add extra tests
for the existing tag as is. Leaving "patch needs improvement" set.
--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:12>

Django

unread,
Feb 5, 2025, 7:05:12 AM2/5/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* type: Cleanup/optimization => New feature
* version: 5.1 => dev

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:13>

Django

unread,
Mar 16, 2025, 11:01:23 PM3/16/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Antoliny):

* cc: Antoliny (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:14>

Django

unread,
Mar 17, 2025, 5:27:54 PM3/17/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):

I took another look since I had a reminder for this work, and the branch
now has conflicts with `main` and there are some comments from Tom to
address. Leaving flags as they are.
--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:15>

Django

unread,
Mar 19, 2025, 7:47:50 AM3/19/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Giannis Terzopoulos):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:16>

Django

unread,
Mar 19, 2025, 3:37:36 PM3/19/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:17>

Django

unread,
Mar 20, 2025, 9:48:12 AM3/20/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Ready for checkin => Accepted

Comment:

We need to solve #36267 before landing this PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:18>

Django

unread,
Mar 24, 2025, 9:51:12 PM3/24/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:19>

Django

unread,
Mar 25, 2025, 11:23:53 AM3/25/25
to django-...@googlegroups.com
#35529: Have the template tag query_string support multiple arguments and arguments
of type Mapping[str, Any]
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Giannis
| Terzopoulos
Type: New feature | Status: closed
Component: Template system | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"a39c28706aa7a8c3effd0980ae6d59ae67299d85" a39c287]:
{{{#!CommitTicketReference repository=""
revision="a39c28706aa7a8c3effd0980ae6d59ae67299d85"
Fixed #35529 -- Added support for positional arguments in querystring
template tag.

Co-authored-by: Natalia <124304+...@users.noreply.github.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35529#comment:20>
Reply all
Reply to author
Forward
0 new messages