[Django] #22195: Use constants to define built-in tags

6 views
Skip to first unread message

Django

unread,
Mar 3, 2014, 6:18:40 AM3/3/14
to django-...@googlegroups.com
#22195: Use constants to define built-in tags
-------------------------------------+-------------------------------------
Reporter: russellm | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.7-alpha-1
Component: Core | Keywords:
(System checks) | Has patch: 0
Severity: Normal | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 1
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Via discussion on [https://groups.google.com/forum/#!msg/django-
developers/GeAWvy_V0sQ/09DFkcNTJ3wJ django-developers]:

The code for system checks currently uses freeform strings to register
against tags (e.g., `@register('compatibility')`).

This is potentially prone to error, since you can easily mistype the
string, and then the check won't get caught by the tag.

Internally, we should be using constants for built-in tags.

--
Ticket URL: <https://code.djangoproject.com/ticket/22195>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 18, 2014, 7:48:11 PM3/18/14
to django-...@googlegroups.com
#22195: Use constants to define built-in tags
-------------------------------------+-------------------------------------
Reporter: russellm | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version:
Component: Core (System | 1.7-alpha-1
checks) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by timmartin):

* cc: timmartin (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/22195#comment:1>

Django

unread,
Mar 31, 2014, 8:37:40 AM3/31/14
to django-...@googlegroups.com
#22195: Use constants to define built-in tags
-------------------------------------+-------------------------------------
Reporter: russellm | Owner: Elvard
Type: | Status: assigned

Cleanup/optimization | Version:
Component: Core (System | 1.7-alpha-1
checks) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0

Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by Elvard):

* status: new => assigned
* cc: tomas.ehrlich@… (added)
* has_patch: 0 => 1
* owner: nobody => Elvard


--
Ticket URL: <https://code.djangoproject.com/ticket/22195#comment:2>

Django

unread,
Apr 10, 2014, 8:54:53 AM4/10/14
to django-...@googlegroups.com
#22195: Use constants to define built-in tags
-------------------------------------+-------------------------------------
Reporter: russellm | Owner: Elvard
Type: | Status: closed

Cleanup/optimization | Version:
Component: Core (System | 1.7-alpha-1
checks) | Resolution: fixed

Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"32e62374506827723423471a115e6b25313ed887"]:
{{{
#!CommitTicketReference repository=""
revision="32e62374506827723423471a115e6b25313ed887"
[1.7.x] Fixed #22195 -- Used constants to define built-in tags for check
framework.

Thanks Elvard for the patch.

Backport of b513fa5fc6 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22195#comment:3>

Reply all
Reply to author
Forward
0 new messages