[Django] #32910: Contrib apps: Different plural forms for Slovak

3 views
Skip to first unread message

Django

unread,
Jul 7, 2021, 5:30:14 AM7/7/21
to django-...@googlegroups.com
#32910: Contrib apps: Different plural forms for Slovak
------------------------------------------------+------------------------
Reporter: Martin Svoboda | Owner: nobody
Type: Uncategorized | Status: new
Component: Internationalization | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
#30439 has cause translations with different plural forms definitions are
loaded in a separated catalogue.

Contrib apps Sites, Redirects and Sessions have different plural form
definitions than other Slovak translations.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 7, 2021, 5:33:48 AM7/7/21
to django-...@googlegroups.com
#32910: Contrib apps: Different plural forms for Slovak (SK)
-------------------------------------+-------------------------------------

Reporter: Martin Svoboda | Owner: nobody
Type: Uncategorized | Status: new
Component: | Version: 3.2
Internationalization |
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Martin Svoboda:

Old description:

> #30439 has cause translations with different plural forms definitions are
> loaded in a separated catalogue.
>
> Contrib apps Sites, Redirects and Sessions have different plural form
> definitions than other Slovak translations.

New description:

#30439 has cause translations with different plural forms definitions are
loaded in a separated catalogue.

Contrib apps Sites, Redirects and Sessions have different plural form

definitions than other Slovak (SK) translations.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:1>

Django

unread,
Jul 7, 2021, 6:09:29 AM7/7/21
to django-...@googlegroups.com
#32910: Contrib apps: Different plural forms for Slovak (SK)
--------------------------------------+------------------------------------

Reporter: Martin Svoboda | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

We backported #30439. We need to decide whether that's required here too
(or if it's just a cleanup)

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:2>

Django

unread,
Jul 7, 2021, 6:11:04 AM7/7/21
to django-...@googlegroups.com
#32910: Contrib apps: Different plural forms for Slovak (SK)
--------------------------------------+------------------------------------

Reporter: Martin Svoboda | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: 3.2

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* cc: Claude Paroz (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:3>

Django

unread,
Jul 7, 2021, 8:02:15 AM7/7/21
to django-...@googlegroups.com
#32910: Contrib apps: Different plural forms for Slovak (SK)
--------------------------------------+------------------------------------

Reporter: Martin Svoboda | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: 3.2

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Martin Svoboda):

Pull request https://github.com/django/django/pull/14604

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:4>

Django

unread,
Jul 14, 2021, 4:44:27 AM7/14/21
to django-...@googlegroups.com
#32910: Contrib apps: Different plural forms for Slovak (SK)
-------------------------------------+-------------------------------------

Reporter: Martin Svoboda | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* version: 3.2 => 2.2
* stage: Accepted => Ready for checkin


Comment:

I think we should update plural forms for all languages and backport this
changes.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:5>

Django

unread,
Jul 14, 2021, 5:33:27 AM7/14/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
Type: | Felisiak
Cleanup/optimization | Status: assigned

Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak
* status: new => assigned


Comment:

There are more affected languages I will fetch translations from Transifex
and prepare PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:6>

Django

unread,
Jul 14, 2021, 6:52:36 AM7/14/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned

Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* type: Cleanup/optimization => Bug


Comment:

[https://github.com/django/django/pull/14636 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:7>

Django

unread,
Jul 14, 2021, 8:19:36 AM7/14/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

I don't think the backports are needed, isn't this only an optimization?

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:8>

Django

unread,
Jul 14, 2021, 8:57:23 AM7/14/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Replying to [comment:8 Claude Paroz]:


> I don't think the backports are needed, isn't this only an optimization?

I assumed that e3e48b00127c09eafe6439d980a82fc5c591b673 broke the previous
behavior for users using multiple contrib apps, but I'm not an expert in
this area.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:9>

Django

unread,
Jul 14, 2021, 2:09:45 PM7/14/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Claude, if you think that backport is not necessary, I'd be more than
happy to merge this to the `main` branch only.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:10>

Django

unread,
Jul 14, 2021, 2:29:36 PM7/14/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Ready for checkin => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:11>

Django

unread,
Jul 15, 2021, 3:45:22 AM7/15/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

As I see it, the PR is improving things in that only one catalog is
created for each language. But even in the current situation, I don't
really see a bug (or the PR should demonstrate it with a regression test).
See also that most or all affected catalogs don't contain any plural
strings.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:12>

Django

unread,
Jul 15, 2021, 3:55:19 AM7/15/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Replying to [comment:12 Claude Paroz]:


> As I see it, the PR is improving things in that only one catalog is
created for each language. But even in the current situation, I don't
really see a bug (or the PR should demonstrate it with a regression test).
See also that most or all affected catalogs don't contain any plural
strings.

Thanks for the clarification. I updated PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:13>

Django

unread,
Jul 15, 2021, 2:42:33 PM7/15/21
to django-...@googlegroups.com
#32910: Different plural forms for some languages.
-------------------------------------+-------------------------------------
Reporter: Martin Svoboda | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: | Version: 2.2
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"a56531ab1b772ee4ae94dd805f168761887354c6" a56531ab]:
{{{
#!CommitTicketReference repository=""
revision="a56531ab1b772ee4ae94dd805f168761887354c6"
Fixed #32910 -- Unified different plural equations for the same language
in contrib apps.

Thanks Martin Svoboda for the report and initial patch.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32910#comment:14>

Reply all
Reply to author
Forward
0 new messages