[Django] #24426: Admin actions panel is always hidden if show_full_result_count = False
Django
-------------------------------+----------------------
Reporter: shultais | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 1.8beta1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------
django.contrib.admin.views.main.py
{{{
if self.model_admin.show_full_result_count:
if self.get_filters_params() or self.params.get(SEARCH_VAR):
full_result_count = self.root_queryset.count()
else:
full_result_count = result_count
else:
full_result_count = None
}}}
if show_full_result_count is False then full_result_count = None
{{{
self.show_full_result_count = self.model_admin.show_full_result_count
...
self.show_admin_actions = self.show_full_result_count or
bool(full_result_count)
}}}
But show_full_result_count is False and bool(full_result_count) is also
False
self.show_admin_actions is always hidden
--
Ticket URL: <https://code.djangoproject.com/ticket/24426>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: shultais | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8beta1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* severity: Normal => Release blocker
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted
Comment:
Release blocker since it's a bug in a new feature in 1.8
(`ModelAdmin.show_full_result_count`).
--
Ticket URL: <https://code.djangoproject.com/ticket/24426#comment:1>
Django
Reporter: shultais | Owner: timgraham
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.8beta1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* owner: nobody => timgraham
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24426#comment:2>
Django
Reporter: shultais | Owner: timgraham
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24426#comment:3>
Django
Reporter: shultais | Owner: timgraham
Component: contrib.admin | Version: 1.8beta1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"36a17be9f3cf6081f7e6f83fcfeae3d09ce8a72b"]:
{{{
#!CommitTicketReference repository=""
revision="36a17be9f3cf6081f7e6f83fcfeae3d09ce8a72b"
Fixed #24426 -- Displayed admin actions panel when
show_full_result_count=False.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24426#comment:4>
Django
Reporter: shultais | Owner: timgraham
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"20bf3205027fe581b8f33cd98b164f16a801c813"]:
{{{
#!CommitTicketReference repository=""
revision="20bf3205027fe581b8f33cd98b164f16a801c813"
[1.8.x] Fixed #24426 -- Displayed admin actions panel when
show_full_result_count=False.
Backport of 36a17be9f3cf6081f7e6f83fcfeae3d09ce8a72b from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24426#comment:5>