Re: [Django Code] #6094: core handlers do not catch middleware exceptions

[Django Code]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone: 1.0
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------
Changes (by anonymous):

* cc: trevor (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:17>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

[Django Code]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone: 1.0
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by Michael P. Jung):

* cc: mpj...@terreon.de (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:18>

[Django Code]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson

Status: assigned | Milestone: post-1.0

Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by jacob):

* milestone: 1.0 => post-1.0

Comment:

Pushing post-1.0: at this point this will destabilize the core handler a
bit too much for my liking. We've lived with this annoyance for a while;
we can deal with it for a bit longer still.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:19>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone: post-1.0
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by jbalogh):

* cc: m...@jeffbalogh.org (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:20>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone: post-1.0
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by isagalaev):

* cc: Man...@SoftwareManiacs.Org (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:21>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone:

Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by groks):

* cc: sde...@gmail.com (added)

Comment:

Replying to [comment:19 jacob]:

> Pushing post-1.0: at this point this will destabilize the core handler a
bit too much for my liking. We've lived with this annoyance for a while;
we can deal with it for a bit longer still.

It's now post 1.0 (and post 1.1, I guess). Any chance you can take another
look at this?

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:23>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by carljm):

* cc: carljm (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:24>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by gonz):

* cc: gonz (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:25>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by jdunck):

* cc: jdu...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:26>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by gvangool):

* cc: gvangool (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:27>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: assigned | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Comment (by isagalaev):

I've made an alternative patch that is much less involving than the
previous one. Basically it just shoves request middleware handling under
`try` statements in BaseHandler.

Refactoring of the request part is a good thing by itself but I think it
holds this actual bug from fixing. It can be done after it's closed.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:28>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson

Status: reopened | Milestone:

Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by EroSennin):

* status: closed => reopened
* resolution: fixed =>

Comment:

After [12186] it is broken again - reopening.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:31>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: reopened | Milestone:
Component: HTTP handling | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------
Changes (by EroSennin):

* cc: EroSennin (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:32>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson

Status: closed | Milestone:

Component: HTTP handling | Version: SVN

Resolution: fixed | Keywords:

Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Changes (by kmtracey):

* status: reopened => closed
* resolution: => fixed

Comment:

Please open a new ticket describing the current problem. It's hard to
determine what is meant by "broken again"; a fresh problem that actually
describes the current situation is much better than reopening a ticket
with 2 years of history to dig through to figure out what you might be
trying to report.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:33>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: closed | Milestone:
Component: HTTP handling | Version: SVN
Resolution: fixed | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Comment (by EroSennin):

Do you want me to copy&paste the description of this ticket into a new
one? Fine.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:34>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: closed | Milestone:
Component: HTTP handling | Version: SVN
Resolution: fixed | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Comment (by kmtracey):

Sigh. I'd like a description of what made you even go find this ticket. I
tried the first thing in the description -- putting an exception in a
middleware process_request -- and got a debug page, not a bare exception.
So something has been fixed, and it would help if you could explain
exactly what you see that has not been fixed.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:35>

[Django]

#6094: core handlers do not catch middleware exceptions
------------------------------------+---------------------------------------
Reporter: gwilson | Owner: gwilson
Status: closed | Milestone:
Component: HTTP handling | Version: SVN
Resolution: fixed | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------+---------------------------------------

Comment (by EroSennin):

OK, created #13090.

--
Ticket URL: <http://code.djangoproject.com/ticket/6094#comment:36>