Re: [Django] #35085: Import of PyATS breaks runserver reloader
Django
------------------------------+--------------------------------------
Reporter: Andy Norwood | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: 4.2
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Comment (by Natalia Bidart):
Thank you Tim, I double checked and while I did install `pyats` and added
an adequate import to my `views.py`, due to a previous ticket triaging I
had temporarily removed the corresponding `urls.py` from my Django project
config :facepalm:.
Andy, I agree with Tim's comment in that we would need to understand why
`pyats` is providing modules that are not hashable. I searched a bit and I
couldn't find concrete Python docs regarding modules and their
hashability, though I did find
[https://bytes.com/topic/python/answers/35503-modules-hashable this post].
I'm inclined to suggest that `pyats` may need to ensure their modules are
hashable, or explain why they are not/can not be so we can evaluate how
niche vs common that reason is.
--
Ticket URL: <https://code.djangoproject.com/ticket/35085#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
------------------------------+--------------------------------------
Reporter: Andy Norwood | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: 4.2
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Comment (by Andy Norwood):
Thank you both for looking at this.
I have contacted pyats support and pointed them to this ticket in the hope
that they can share some insight that might help find a way forward.
--
Ticket URL: <https://code.djangoproject.com/ticket/35085#comment:4>
Django
------------------------------+--------------------------------------
Reporter: Andy Norwood | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: 4.2
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Comment (by Andy Norwood):
An update from Cisco PyATS team:
----
''Hi Andy,''
''Thanks for reaching out. I believe this was done to create a singleton
object for the pyATS configuration data that is used by the pyATS code in
several places.''
''Using the sys.modules structure for a non-module is a hack done a long
time ago, we will review alternative options to handle this in the pyATS
code.''
''Regards,''
''Dave''
----
Sounds like the ball is in their court to resolve the 'hack'.
--
Ticket URL: <https://code.djangoproject.com/ticket/35085#comment:5>
Django
------------------------------+--------------------------------------
Reporter: Andy Norwood | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: 4.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
* resolution: needsinfo => wontfix
Comment:
Thank you a lot Andy for the follow up! I'll change the status to
`wontfix` given the latest information, but feel free to comment if (for
any reason) that needs to be changed.
--
Ticket URL: <https://code.djangoproject.com/ticket/35085#comment:6>
Django
------------------------------+--------------------------------------
Reporter: Andy Norwood | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: 4.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
* resolution: wontfix => invalid
Comment:
Marking as "invalid" because it's not an issue in Django so there is
nothing to fix on our side.
--
Ticket URL: <https://code.djangoproject.com/ticket/35085#comment:7>
Django
------------------------------+--------------------------------------
Reporter: Andy Norwood | Owner: nobody
Type: Bug | Status: closed
Component: Utilities | Version: 4.2
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
#35756 was a duplicate
--
Ticket URL: <https://code.djangoproject.com/ticket/35085#comment:8>