Re: [Django] #15844: Filtering by related objects causes unnecessary extra db hits when using model inheritance

8 views
Skip to first unread message

Django

unread,
Aug 17, 2011, 6:27:04 PM8/17/11
to django-...@googlegroups.com
#15844: Filtering by related objects causes unnecessary extra db hits when using
model inheritance
-------------------------------------+-------------------------------------
Reporter: emulbreh | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: SVN | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 0 | Needs tests: 0
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by emulbreh):

* has_patch: 0 => 1
* ui_ux: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/15844#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 15, 2011, 12:36:22 AM9/15/11
to django-...@googlegroups.com
#15844: Filtering by related objects causes unnecessary extra db hits when using
model inheritance
-------------------------------------+-------------------------------------
Reporter: emulbreh | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: SVN | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 0
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by ptone):

* needs_better_patch: 0 => 1


Comment:

Why were code comments deleted in patch? They still seem valid, otherwise
they should be updated not deleted.

--
Ticket URL: <https://code.djangoproject.com/ticket/15844#comment:3>

Django

unread,
Oct 2, 2015, 7:58:53 PM10/2/15
to django-...@googlegroups.com
#15844: Filtering by related objects causes unnecessary extra db hits when using
model inheritance
-------------------------------------+-------------------------------------
Reporter: emulbreh | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0


Comment:

Looks like this was fixed in Django 1.6 with
97774429aeb54df4c09895c07cd1b09e70201f7d.

[https://github.com/django/django/pull/5386 PR] to add a regression test.

--
Ticket URL: <https://code.djangoproject.com/ticket/15844#comment:4>

Django

unread,
Oct 3, 2015, 8:30:12 AM10/3/15
to django-...@googlegroups.com
#15844: Filtering by related objects causes unnecessary extra db hits when using
model inheritance
-------------------------------------+-------------------------------------
Reporter: emulbreh | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"fa2e1e633ac2073906ed3f1f32107d02331107aa" fa2e1e63]:
{{{
#!CommitTicketReference repository=""
revision="fa2e1e633ac2073906ed3f1f32107d02331107aa"
Refs #15844 -- Added tests for multi-table inheritance related object
filtering efficiency.

Fixed in 97774429aeb54df4c09895c07cd1b09e70201f7d.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15844#comment:5>

Django

unread,
Oct 3, 2015, 8:34:34 AM10/3/15
to django-...@googlegroups.com
#15844: Filtering by related objects causes unnecessary extra db hits when using
model inheritance
-------------------------------------+-------------------------------------
Reporter: emulbreh | Owner: nobody
Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: new => closed
* resolution: => fixed


--
Ticket URL: <https://code.djangoproject.com/ticket/15844#comment:6>

Reply all
Reply to author
Forward
0 new messages