Re: [Django] #9523: Restart runserver after translation MO files change
Django
-------------------------------------+-------------------------------------
Reporter: wim@… | Owner: nobody
Type: New | Status: new
feature | Component:
Milestone: | Internationalization
Version: 1.0 | Severity: Normal
Resolution: | Keywords:
Triage Stage: | Has patch: 0
Someday/Maybe | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Changes (by trebor74hr):
* cc: trebor74hr@… (added)
* easy: => 0
--
Ticket URL: <http://code.djangoproject.com/ticket/9523#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: wim@… | Owner: nobody
Component: | Version: 1.0
Internationalization | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bmihelac):
* cc: bmihelac@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: wim@… | Owner: nobody
Type: New feature | Status: new
Component: | Version: 1.0
Internationalization | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: charette.s@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:7>
Django
Reporter: wim@… | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* stage: Someday/Maybe => Accepted
Comment:
I think this ticket should be "accepted".
Malcolm's had two objections: it's low priority, and it isn't obvious to
implement. But if someone writes a good patch, we'll certainly consider
it.
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:8>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* has_patch: 0 => 1
Comment:
I provided a pull request fixing this issue:
https://github.com/django/django/pull/1283
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:9>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* needs_tests: 0 => 1
Comment:
I've left some comments on the [https://github.com/django/django/pull/1799
rebased PR]. I'd like to see this tested in some way -- based on the
coverage report, none of django/utils/autoreload.py is tested.
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:10>
Django
--------------------------------------+------------------------------------
Type: New feature | Status: assigned
Component: Internationalization | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* status: new => assigned
* cc: bouke (added)
* owner: nobody => bouke
Comment:
I've updated the PR and I included a few tests for the `gen_filenames`
helper. The autoreloader is in the `omit` section of `.coveragerc`, so
that's why there's no coverage at all.
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:11>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Component: Internationalization | Version: 1.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Aymeric Augustin <aymeric.augustin@…>):
In [changeset:"8b3d9d96ed8304d749c9056c42be89084d9b34aa"]:
{{{
#!CommitTicketReference repository=""
revision="8b3d9d96ed8304d749c9056c42be89084d9b34aa"
Merge pull request #1799 from Bouke/tickets/9523
Fixed #9523 -- Restart runserver after translation MO files change
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:13>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Type: New feature | Status: closed
Component: Internationalization | Version: 1.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"c3936c0d79d79aced25ceba8beff0c91a6b5c2ed"]:
{{{
#!CommitTicketReference repository=""
revision="c3936c0d79d79aced25ceba8beff0c91a6b5c2ed"
Fixed #9523 -- Restart runserver after translation MO files change
Thanks to Krzysztof Kulewski for the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:12>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Component: Internationalization | Version: 1.0
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* status: closed => new
* resolution: fixed =>
* needs_tests: 1 => 0
Comment:
Translations in INSTALLED_APPS, which Django might use, are not being
watched. By inspecting INSTALLED_APPS, this can be fixed.
PR: https://github.com/django/django/pull/1878
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:14>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by bouke):
* version: 1.0 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:15>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Component: Internationalization | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"2397daab4a1b95a055514b009818730f4dfc4799"]:
{{{
#!CommitTicketReference repository=""
revision="2397daab4a1b95a055514b009818730f4dfc4799"
Fixed #9523 -- Restart runserver after compiling apps translations
Django also uses locales provided by apps, which also might change. Also
when
i18n is disabled, there is no need for watching translation files.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:16>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Type: New feature | Status: closed
Component: Internationalization | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"0d363b25b82b0a86b7243512470f364bef92bc3d"]:
{{{
#!CommitTicketReference repository=""
revision="0d363b25b82b0a86b7243512470f364bef92bc3d"
Fixed #22857 -- Reset translations when only .mo file changed
No need to restart the server when a translation file changes.
Refs #9523. Thanks artscoop for the report and Tim Graham for
the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:17>
Django
--------------------------------------+------------------------------------
Reporter: wim@… | Owner: bouke
Type: New feature | Status: closed
Component: Internationalization | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"cbcb7c010bdc015c79b4b8a0ba2955abb23aee82"]:
{{{
#!CommitTicketReference repository=""
revision="cbcb7c010bdc015c79b4b8a0ba2955abb23aee82"
[1.7.x] Fixed #22857 -- Reset translations when only .mo file changed
No need to restart the server when a translation file changes.
Refs #9523. Thanks artscoop for the report and Tim Graham for
the review.
Backport of 0d363b25b8 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/9523#comment:18>