[Django] #18924: test.Client.logout doesn't send user_logged_out signal
Django
-----------------------------------+--------------------
Reporter: awsum | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
As docs say user_logged_out signal should be send wherever logout method
called. Instead of reusing contrib.auth.logout Client doing session clean
up by it's own and doesn't send user_logged_out signal.
Fix: https://github.com/django/django/pull/322
--
Ticket URL: <https://code.djangoproject.com/ticket/18924>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: Bug | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by awsum):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:1>
Django
Type: Bug | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Changes (by mjtamlyn):
* cc: marc.tamlyn@… (added)
* needs_docs: 0 => 1
* stage: Unreviewed => Accepted
Comment:
There's one unused import in the current patch which I've highlighted on
github.
This should be mentioned in release notes as someone may have signals
which now get fired by their tests and are unexpected. There's probably no
need to mention it in the normal docs though.
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:2>
Django
Type: Bug | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 1
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by mjtamlyn):
* stage: Accepted => Ready for checkin
Comment:
Subject to release notes, this is now RFC.
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:3>
Django
Reporter: awsum | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 1
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by anonymous):
Can we have this anytime soon?
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:4>
Django
Reporter: awsum | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Changes (by mjtamlyn):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Patch has now gone stale - it will need updating for custom user models.
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:5>
Django
Reporter: awsum | Owner: fhahn
Type: Bug | Status: assigned
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Changes (by fhahn):
* status: new => assigned
* needs_better_patch: 1 => 0
* owner: nobody => fhahn
* cc: flo@… (added)
Comment:
I've updated the patch (after contacting the creator of the patch) and
created a new pull request: https://github.com/django/django/pull/731
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:6>
Django
Reporter: awsum | Owner: fhahn
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a35ed202419a054a9125ee6205a1a7b4eb3cb46d"]:
{{{
#!CommitTicketReference repository=""
revision="a35ed202419a054a9125ee6205a1a7b4eb3cb46d"
Fixed #18924 -- Made test.Client.logout send user_logged_out signal.
Thanks awsum for the suggestion and Pavel Ponomarev and
Florian Hahn for the patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18924#comment:7>