[Django] #25959: Outdated Django docs

7 views
Skip to first unread message

Django

unread,
Dec 21, 2015, 10:34:10 AM12/21/15
to django-...@googlegroups.com
#25959: Outdated Django docs
--------------------------------------+------------------------------
Reporter: SimonSteinberger | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.9
Severity: Normal | Keywords: logging, example
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------
The first example config for Django's new logger still includes the old
logger:

https://docs.djangoproject.com/en/1.9/topics/logging/#configuring-logging


{{{
'loggers': {
'django.request': {
'handlers': ['file'],
'level': 'DEBUG',
'propagate': True,
},
},

}}}

Should be:

{{{

'loggers': {
'django': {
'handlers': ['file'],
'level': 'DEBUG',
'propagate': True,
},
},
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25959>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 21, 2015, 11:10:29 AM12/21/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
--------------------------------------+------------------------------------

Reporter: SimonSteinberger | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: logging, example | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_tests: => 0
* easy: 0 => 1
* needs_docs: => 0
* stage: Unreviewed => Accepted


Comment:

The example is still valid if you only want to capture output from the
'django.request` logger, but I agree a better example would be to use the
'django' logger.

--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:1>

Django

unread,
Dec 22, 2015, 9:53:49 AM12/22/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
-------------------------------------+-------------------------------------
Reporter: SimonSteinberger | Owner:
Type: | PramodBisht
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9

Severity: Normal | Resolution:
Keywords: logging, example | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by PramodBisht):

* owner: nobody => PramodBisht
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:2>

Django

unread,
Dec 22, 2015, 9:54:41 AM12/22/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
-------------------------------------+-------------------------------------
Reporter: SimonSteinberger | Owner:
Type: | PramodBisht
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9

Severity: Normal | Resolution:
Keywords: logging, example | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by PramodBisht):

* cc: pramodpsb@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:3>

Django

unread,
Dec 23, 2015, 1:34:29 PM12/23/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
-------------------------------------+-------------------------------------
Reporter: SimonSteinberger | Owner:
Type: | PramodBisht
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: logging, example | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by varun):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:4>

Django

unread,
Dec 23, 2015, 6:51:48 PM12/23/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
-------------------------------------+-------------------------------------
Reporter: SimonSteinberger | Owner:
Type: | PramodBisht
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9

Severity: Normal | Resolution:
Keywords: logging, example | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

Left some comments on the [https://github.com/django/django/pull/5865 pull
request].

--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:5>

Django

unread,
Dec 24, 2015, 10:08:02 AM12/24/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
-------------------------------------+-------------------------------------
Reporter: SimonSteinberger | Owner:
Type: | PramodBisht
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.9
Severity: Normal | Resolution: fixed

Keywords: logging, example | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"483e0091e3891dc4ed898ea0dbf6923c166f0674" 483e0091]:
{{{
#!CommitTicketReference repository=""
revision="483e0091e3891dc4ed898ea0dbf6923c166f0674"
Fixed #25959 -- Updated logging example to use the django logger.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:6>

Django

unread,
Dec 24, 2015, 10:08:16 AM12/24/15
to django-...@googlegroups.com
#25959: Update logging example to use the django logger
-------------------------------------+-------------------------------------
Reporter: SimonSteinberger | Owner:
Type: | PramodBisht
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.9

Severity: Normal | Resolution: fixed
Keywords: logging, example | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"fa21766230519eba1c7f14021b9647c8d29f5999" fa217662]:
{{{
#!CommitTicketReference repository=""
revision="fa21766230519eba1c7f14021b9647c8d29f5999"
[1.9.x] Fixed #25959 -- Updated logging example to use the django logger.

Backport of 483e0091e3891dc4ed898ea0dbf6923c166f0674 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25959#comment:7>

Reply all
Reply to author
Forward
0 new messages