[Django] #28685: Visual issue with Select2 input widget
Django
-------------------------------------------+------------------------
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------------+------------------------
Playing with the new Django 2.0 feature, Select2 widget in admin, I
noticed a bad position of the last element of the first line in the input
box itself. Please see the 3 little screenshots attached, each one
correspond to a different browser (Firefox, Chrome, Opera).
I do not paste my code here, since I consider it's irrelevant, please ask
if you need.
--
Ticket URL: <https://code.djangoproject.com/ticket/28685>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Antoine Lorence):
* Attachment "opera_2017-10-06_08-48-42.png" added.
Opera screenshot
Django
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Antoine Lorence):
* Attachment "firefox_2017-10-06_08-52-32.png" added.
Firefox screenshot example
Django
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Antoine Lorence):
* Attachment "chrome_2017-10-06_08-51-37.png" added.
Chrome screenshot
Django
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Antoine Lorence):
* Attachment "opera_2017-10-06_08-48-42.png" added.
Opera screenshot
Django
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Description changed by Antoine Lorence:
Old description:
> Playing with the new Django 2.0 feature, Select2 widget in admin, I
> noticed a bad position of the last element of the first line in the input
> box itself. Please see the 3 little screenshots attached, each one
> correspond to a different browser (Firefox, Chrome, Opera).
> I do not paste my code here, since I consider it's irrelevant, please ask
> if you need.
New description:
Playing with the new Django 2.0 feature, Select2 widget in admin, I
noticed a bad position of the last element of the first line in the input
box itself. Please see the 3 little screenshots attached, each one
correspond to a different browser (Firefox, Chrome, Opera).
The behavior seems related to the "clear" button added on the top-right of
the input when at least 1 element has been added to the widget.
I do not paste models and admin code here, since it's probably irrelevant.
Please ask if needed.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:1>
Django
---------------------------------+------------------------------------
Reporter: Antoine Lorence | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Tim Graham):
* cc: Johannes Hoppe (added)
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:2>
Django
Reporter: Antoine Lorence | Owner: Johannes
| Hoppe
Type: Bug | Status: assigned
Component: contrib.admin | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Johannes Hoppe):
* owner: nobody => Johannes Hoppe
* status: new => assigned
* easy: 0 => 1
Comment:
Thank you Antoine! Good catch, that certainly looks wrong. I will check it
out asap!
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Antoine Lorence | Owner: Johannes
| Hoppe
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Johannes Hoppe):
* has_patch: 0 => 1
Comment:
Antoine could you do me the favor and test my patch :)
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Antoine Lorence | Owner: Johannes
| Hoppe
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Antoine Lorence):
I can confirm the patch fixed the floating issue on my model. Thanks !
[[Image(https://i.imgur.com/DHmsCAq.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Antoine Lorence | Owner: Johannes
| Hoppe
Component: contrib.admin | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"3a191bd4abf9937e11504e66a7e5167910c0ab84" 3a191bd]:
{{{
#!CommitTicketReference repository=""
revision="3a191bd4abf9937e11504e66a7e5167910c0ab84"
Fixed #28685 -- Fixed awkward wrapping of Select2 chips.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Antoine Lorence | Owner: Johannes
| Hoppe
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"5825212440d7266e1d4ba9795d490f2b6a8c7f73" 58252124]:
{{{
#!CommitTicketReference repository=""
revision="5825212440d7266e1d4ba9795d490f2b6a8c7f73"
[2.0.x] Fixed #28685 -- Fixed awkward wrapping of Select2 chips.
Backport of 3a191bd4abf9937e11504e66a7e5167910c0ab84 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28685#comment:7>