[Django] #35507: Use search element for admin's filter sidebar

[Django]

#35507: Use search element for admin's filter sidebar
-----------------------------------------+-------------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Keywords: accessibility
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+-------------------------------
Using a search landmark instead of a div will improve the accessibility
for screen readers.

We should ensure that it has a different aria-label than any other search
landmarks or elements with the search role on the page (e.g. search bar)
see: https://developer.mozilla.org/en-
US/docs/Web/Accessibility/ARIA/Roles/Search_role#labeling_landmarks

I didn't check if there are any of these other than the search bar.
--
Ticket URL: <https://code.djangoproject.com/ticket/35507>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35507: Use search element for admin's filter sidebar

-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick

Type: Bug | Status: assigned
Component: contrib.admin | Version: dev

Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+---------------------------------------
Changes (by Tom Carrick):

* owner: nobody => Tom Carrick

--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:1>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------------------------

Comment (by icastellanox):

I've made the pull request: https://github.com/django/django/pull/18256
--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:2>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------------------------

Changes (by Paolo Melchiorre):

* cc: Paolo Melchiorre (added)
* has_patch: 0 => 1
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:3>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------------------------

Comment (by Natalia Bidart):

For further information, see description of the `search` element in
[https://developer.mozilla.org/en-US/docs/Web/HTML/Element/search this
link], specifically:

> The <search> element semantically identifies the purpose of the
element's contents as having search or filtering capabilities.
--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:4>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------------------------

Changes (by Sarah Boyce):

* cc: Thibaud Colas (added)
* needs_better_patch: 0 => 1

Comment:

This appears to revert #34835 which was introduced in 5.1, makes me think
we should backport this to 5.1 before the beta freeze and mark this as a
release blocker if we are instead saying this is in fact more accurate. We
would also need to update the release note added in #34835.
Otherwise, we can close this ticket as wontfix.
--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:5>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------------------------

Comment (by Tom Carrick):

So... I feel uncomfortable with this phrasing a little. I think `nav` was
an improvement, and this is a further improvement. It could be backported,
I don't have a problem with that either, but I wouldn't go so far as to
say that `nav` was wrong, just that this is "more right".
--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:6>

[Django]

#35507: Use search element for admin's filter sidebar

-------------------------------+----------------------------------------
Reporter: Tom Carrick | Owner: icastellanox

Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0

-------------------------------+----------------------------------------
Changes (by Sarah Boyce):

* owner: Tom Carrick => icastellanox

--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:7>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+------------------------------------

Reporter: Tom Carrick | Owner: Antoliny

Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Changes (by Antoliny):

* owner: icastellanox => Antoliny

--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:8>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------+------------------------------------
Reporter: Tom Carrick | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Antoliny):

* needs_better_patch: 1 => 0

Comment:

[https://github.com/django/django/pull/19379 New PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:9>

[Django]

#35507: Use search element for admin's filter sidebar

-------------------------------------+-------------------------------------

Reporter: Tom Carrick | Owner: Antoliny
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:10>

[Django]

#35507: Use search element for admin's filter sidebar
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Antoliny

Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"8bc3dd87276a624be3bb47221034b3fc84668469" 8bc3dd87]:
{{{#!CommitTicketReference repository=""
revision="8bc3dd87276a624be3bb47221034b3fc84668469"
Fixed #35507 -- Improved accessibility of search and filter elements in
the admin changelist.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35507#comment:11>