[Django] #23285: Non-deterministic test: admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-----------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Have seen this fail a couple times on Python 3:
{{{
Traceback (most recent call last):
File "/home/jenkins/workspace/django-pull-
requests/database/sqlite3/python/python3.4/tests/admin_views/tests.py",
line 293, in test_change_list_sorting_model_admin_reverse
"Results of sorting on ModelAdmin method are out of order.")
File "/home/jenkins/workspace/django-pull-
requests/database/sqlite3/python/python3.4/tests/admin_views/tests.py",
line 93, in assertContentBefore
failing_msg)
AssertionError: False is not true : Results of sorting on ModelAdmin
method are out of order.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23285>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+------------------------------------
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
Another one:
{{{
Traceback (most recent call last):
File "/home/jenkins/workspace/django-pull-
requests/database/postgres/python/python3.4/tests/admin_filters/tests.py",
line 377, in test_relatedfieldlistfilter_foreignkey
self.assertEqual(filterspec.lookup_choices, expected)
AssertionError: Lists differ: [(50, 'lisa'), (48, 'alfred'), (49, 'bob')]
!= [(48, 'alfred'), (49, 'bob'), (50, 'lisa')]
First differing element 0:
(50, 'lisa')
(48, 'alfred')
- [(50, 'lisa'), (48, 'alfred'), (49, 'bob')]
+ [(48, 'alfred'), (49, 'bob'), (50, 'lisa')]
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:1>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+------------------------------------
Type: Bug | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
The second failure has been addressed in #23380.
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:2>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by parasgithub):
* status: new => assigned
* owner: nobody => parasgithub
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:3>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by parasgithub):
I can't reproduce this.
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:4>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Component: contrib.admin | Version: master
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by parasgithub):
* status: assigned => closed
* resolution: => needsinfo
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:5>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* status: closed => new
* resolution: needsinfo =>
Comment:
There's evidence that it fails at least on the CI server.
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:6>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
Saw the failure on the CI server today on Python 2.
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:7>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Component: contrib.admin | Version: master
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: new => closed
* resolution: => duplicate
Comment:
See #24316 comment 5 for the cause. I'll mark this as a duplicate of that
ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:8>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Type: Bug | Status: closed
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
On second thought, since #24316 likely isn't a candidate for backport, how
about a fix for the 1.8 and 1.9 branches because it's easy:
[https://github.com/django/django/pull/5887 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:9>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* resolution: duplicate => fixed
Comment:
In [changeset:"2939ed4a18864549a25807193ea5af490d632dc6" 2939ed4a]:
{{{
#!CommitTicketReference repository=""
revision="2939ed4a18864549a25807193ea5af490d632dc6"
[1.9.x] Fixed #23285 -- Fixed non-deterministic admin_views test.
This test sometimes fail because the checked integers can appear in the
output as memory addresses due to #24316.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:10>
Django
admin_views.tests.AdminViewBasicTest.test_change_list_sorting_model_admin_reverse
-------------------------------+---------------------------------------
Reporter: timgraham | Owner: parasgithub
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"11601ee826bd3bf42e4bd182f97e5d54b152225d" 11601ee8]:
{{{
#!CommitTicketReference repository=""
revision="11601ee826bd3bf42e4bd182f97e5d54b152225d"
[1.8.x] Fixed #23285 -- Fixed non-deterministic admin_views test.
This test sometimes fail because the checked integers can appear in the
output as memory addresses due to #24316.
Backport of 2939ed4a18864549a25807193ea5af490d632dc6 from stable/1.9.x
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23285#comment:11>