Re: [Django] #9388: Made month and year selectable in admin calender widget.

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Alexander Lazarević):

* Attachment "Screenshot from 2024-01-30 16-45-19.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/9388>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Alexander Lazarević):

I just looked at this and the PR seemed to have gotten pretty far. Patch
still works with the current main branch.

[[Image(Screenshot from 2024-01-30 16-45-19.png)]]

Now two years have passed and I'm not sure what was/is blocking this.

- needs tests? The PR includes the following tests (are more needed?):
- test_show_hide_month_picker_widgets
- test_month_picker_selected_class_and_input
- test_month_picker_prev_next_links
- test_show_hide_year_picker_widgets
- test_year_picker_selected_class_and_input
- needs documentation? The PR changed `docs/releases/4.1.txt` to contain:
> Now admin calendar caption is selectable and opens monthlist and
yearlist. now it's easy adding older dates like birthday via admin
calendar widget
- I briefly checked the following docs and the calendar description
seemed to be still in in sync with what the PR would introduce
- intro/tutorial02.txt
- ref/contrib/sitemaps.txt
- ref/models/fields.txt
- ref/settings.txt
- topics/forms/index.txt
- topics/forms/media.txt
- topics/i18n/timezones.txt
- patch needs improvement? As far as I can tell from the PR, every request
or recommendation was integrated?
- decision to use native datepicker instead is still pending?
- decision to use some other datepicker package instead is still pending?
- something else?
--
Ticket URL: <https://code.djangoproject.com/ticket/9388#comment:18>

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Alexander Lazarević):

* Attachment "Screenshot from 2024-01-30 17-23-25.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/9388>

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Alexander Lazarević):

Seems to work quite nicely with the dark theme as well.

[[Image(Screenshot from 2024-01-30 17-23-25.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/9388#comment:19>

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Thibaud Colas):

Yes, I would say a big problem here is that this builds upon a date picker
widget which we already know has many accessibility flaws and needs a
replacement (see [https://github.com/django/django/pull/15806 Refs #29822
-- Improved date, time and datetime HTML inputs #15806]). Personally I
wouldn’t recommend working on that widget, but if others think incremental
improvements are the path forward that’s a valid call too.

Aside from that – there is also one code review comment on the PR which
the author has yet to address.
--
Ticket URL: <https://code.djangoproject.com/ticket/9388#comment:20>

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili

Type: New feature | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Alexander Lazarević):

* status: assigned => closed
* resolution: => fixed

Comment:

Replying to [comment:20 Thibaud Colas]:

> Yes, I would say a big problem here is that this builds upon a date
picker widget which we already know has many accessibility flaws and needs
a replacement

Ok, that wasn't apparent to me. Thanks for the clarification.
--
Ticket URL: <https://code.djangoproject.com/ticket/9388#comment:21>

[Django]

#9388: Made month and year selectable in admin calender widget.
-------------------------------------+-------------------------------------
Reporter: Fidel Ramos | Owner:
| ahmadkhalili

Type: New feature | Status: new

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: admin calendar year | Triage Stage: Accepted
previous next widget ui |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* status: closed => new
* resolution: fixed =>

Comment:

Closing as "wontfix" might be appropriate but nothing has been fixed as
far as I see.
--
Ticket URL: <https://code.djangoproject.com/ticket/9388#comment:22>