[Django] #33340: DatabaseCache backend doesn't quote all fields in queries
Django
-----------------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------------+------------------------
Snowflake requires all fields to be quoted, otherwise they're treated as
uppercase.
The attached patch works with stable/3.2.x, but I'll have to review it
once [https://github.com/cedar-team/django-snowflake django-snowflake]
development is caught up to Django's main branch.
--
Ticket URL: <https://code.djangoproject.com/ticket/33340>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: dev
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* Attachment "33340.diff" added.
Django
Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: dev
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Thanks for the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/33340#comment:1>
Django
Reporter: Tim Graham | Owner: Arsalan
| Ghassemi
Type: Bug | Status: assigned
Component: Core (Cache system) | Version: dev
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Arsalan Ghassemi):
* owner: nobody => Arsalan Ghassemi
* status: new => assigned
Comment:
Hello, I'm working on a patch for this ticket, the topic branch :
https://github.com/ArsaCode/django/tree/ticket_33340
--
Ticket URL: <https://code.djangoproject.com/ticket/33340#comment:2>
Django
Reporter: Tim Graham | Owner: Arsalan
| Ghassemi
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Arsalan Ghassemi):
* has_patch: 0 => 1
Comment:
Hi,
I opened a PR for this issue : https://github.com/django/django/pull/15166
--
Ticket URL: <https://code.djangoproject.com/ticket/33340#comment:3>
Django
Reporter: Tim Graham | Owner: Arsalan
| Ghassemi
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33340#comment:4>
Django
Reporter: Tim Graham | Owner: Arsalan
| Ghassemi
Type: Bug | Status: assigned
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33340#comment:5>
Django
Reporter: Tim Graham | Owner: Arsalan
| Ghassemi
Component: Core (Cache system) | Version: dev
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"17df72114e222d63c2af9ed9780583f4cb0689eb" 17df7211]:
{{{
#!CommitTicketReference repository=""
revision="17df72114e222d63c2af9ed9780583f4cb0689eb"
Fixed #33340 -- Fixed unquoted column names in queries used by
DatabaseCache.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33340#comment:6>