[Django] #24334: auth admin password reset doesn't work with non-digit custom user PK

6 views
Skip to first unread message

Django

unread,
Feb 12, 2015, 1:45:24 PM2/12/15
to django-...@googlegroups.com
#24334: auth admin password reset doesn't work with non-digit custom user PK
----------------------------------------+---------------------------
Reporter: timgraham | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: 1.8alpha1
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+---------------------------


--
Ticket URL: <https://code.djangoproject.com/ticket/24334>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 12, 2015, 1:46:10 PM2/12/15
to django-...@googlegroups.com
#24334: auth admin password reset doesn't work with non-digit custom user PK
------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.8alpha1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
------------------------------+-------------------------------------
Changes (by timgraham):

* owner: nobody => timgraham
* status: new => assigned
* has_patch: 0 => 1
* needs_better_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/4118 PR] (with one issue to be
fixed)

--
Ticket URL: <https://code.djangoproject.com/ticket/24334#comment:1>

Django

unread,
Feb 12, 2015, 3:52:13 PM2/12/15
to django-...@googlegroups.com
#24334: auth admin password reset doesn't work with non-digit custom user PK
------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.8alpha1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0


Comment:

Test is working now (added `connection.constraint_checks_disabled` to fix
MySQL).

--
Ticket URL: <https://code.djangoproject.com/ticket/24334#comment:2>

Django

unread,
Feb 12, 2015, 8:30:04 PM2/12/15
to django-...@googlegroups.com
#24334: auth admin password reset doesn't work with non-digit custom user PK
------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.8alpha1
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+-------------------------------------
Changes (by timgraham):

* keywords: => 1.8-beta


--
Ticket URL: <https://code.djangoproject.com/ticket/24334#comment:3>

Django

unread,
Feb 13, 2015, 9:49:47 AM2/13/15
to django-...@googlegroups.com
#24334: auth admin password reset doesn't work with non-digit custom user PK
------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: New feature | Status: closed
Component: contrib.auth | Version: 1.8alpha1
Severity: Normal | Resolution: fixed
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"fdf20093e0f8cd064673aa1597c20727ed4dd2a0"]:
{{{
#!CommitTicketReference repository=""
revision="fdf20093e0f8cd064673aa1597c20727ed4dd2a0"
Fixed #24334 -- Allowed admin password reset to work with non-digit custom
user model primary key.

Thanks Loic for help and Simon for review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24334#comment:4>

Django

unread,
Feb 13, 2015, 9:56:35 AM2/13/15
to django-...@googlegroups.com
#24334: auth admin password reset doesn't work with non-digit custom user PK
------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: New feature | Status: closed
Component: contrib.auth | Version: 1.8alpha1
Severity: Normal | Resolution: fixed
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"8fc4840289a0538af005619551c3b67f4f9e1399"]:
{{{
#!CommitTicketReference repository=""
revision="8fc4840289a0538af005619551c3b67f4f9e1399"
[1.8.x] Fixed #24334 -- Allowed admin password reset to work with non-


digit custom user model primary key.

Thanks Loic for help and Simon for review.

Backport of fdf20093e0f8cd064673aa1597c20727ed4dd2a0 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24334#comment:5>

Reply all
Reply to author
Forward
0 new messages