Re: [Django] #6445: models.ForeignKey should accept instances as default value

4 views
Skip to first unread message

Django

unread,
Mar 21, 2019, 10:41:26 AM3/21/19
to django-...@googlegroups.com
#6445: models.ForeignKey should accept instances as default value
-------------------------------------+-------------------------------------
Reporter: eikke@… | Owner: Philippe
| Raoult
Type: | Status: closed
Component: Core (Other) | Version: master
Severity: | Resolution: fixed
Keywords: foreignkey default | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Clayton Daley):

* ui_ux: => 0
* easy: => 0


Comment:

Was this behavior intentionally reverted? In Django 2.1.7, I'm getting
the error:

> TypeError: int() argument must be a string, a bytes-like object or a
number, not 'Group'

It's coming from this code (because I can fix it by adding `.pk` to the
`get` call):

{{{
# Can't serialize lambdas in migrations, but functions are fine
def const_my_group():
return Group.objects.get(name=settings.MY_GROUP)

class Task(models.Model):
group = models.ForeignKey(Group, default=const_my_group,
on_delete=models.PROTECT)
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/6445#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 21, 2019, 10:55:19 AM3/21/19
to django-...@googlegroups.com
#6445: models.ForeignKey should accept instances as default value
-------------------------------------+-------------------------------------
Reporter: eikke@… | Owner: Philippe
| Raoult
Type: Uncategorized | Status: closed

Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed

Keywords: foreignkey default | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* type: => Uncategorized
* severity: => Normal


Comment:

Yes, you should use `.pk` -- see #25129.

--
Ticket URL: <https://code.djangoproject.com/ticket/6445#comment:6>

Reply all
Reply to author
Forward
0 new messages