[Django] #23583: makemessages for javascript no longer works
Django
------------------------------+--------------------
Reporter: nijel | Owner: nobody
Type: Bug | Status: new
Component: Translations | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------
When using manage.py makemessages -d djangojs, it no longer works (for me)
as makemessages now completely ignores media and static dirs, what's place
where javscript is usually stored. This has been introduced as fix for
issue #23010.
--
Ticket URL: <https://code.djangoproject.com/ticket/23583>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: nijel | Owner: nobody
Type: Bug | Status: new
Component: Translations | Version: 1.7
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by nijel):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Pull request: https://github.com/django/django/pull/3298
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:1>
Django
Reporter: nijel | Owner: nobody
Type: Bug | Status: closed
Component: Translations | Version: 1.7
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by claudep):
* status: new => closed
* resolution: => invalid
Comment:
`STATIC_ROOT` is not supposed to point to where your static files are
located in your source code, but where you deploy them. I think you might
be misusing the static files framework.
https://docs.djangoproject.com/en/1.7/ref/settings/#std:setting-
STATIC_ROOT
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:2>
Django
Reporter: nijel | Owner: nobody
Type: Bug | Status: new
Component: Translations | Version: 1.7
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by blodone):
* status: closed => new
* has_patch: 1 => 0
* resolution: invalid =>
Old description:
> When using manage.py makemessages -d djangojs, it no longer works (for
> me) as makemessages now completely ignores media and static dirs, what's
> place where javscript is usually stored. This has been introduced as fix
> for issue #23010.
New description:
makemessages ignores any in-app paths that begin with static because of
this line:
https://github.com/django/django/blob/master/django/core/management/commands/makemessages.py#L233
it should ignore something like "<path>/*" but not "<path>*"
reproducible:
https://github.com/blodone/django_static_broken
--
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:3>
Django
Reporter: nijel | Owner: claudep
Type: Bug | Status: assigned
Component: Internationalization | Version: 1.7
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* status: new => assigned
* severity: Normal => Release blocker
* needs_better_patch: 0 => 1
* component: Translations => Internationalization
* owner: nobody => claudep
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:4>
Django
Reporter: nijel | Owner: claudep
Type: Bug | Status: assigned
Component: Internationalization | Version: 1.7
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* needs_better_patch: 1 => 0
Comment:
Alternative patch: https://github.com/django/django/pull/3386
Review welcome (possibly on Windows). This is a candidate for 1.7.1.
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:5>
Django
Reporter: nijel | Owner: claudep
Type: Bug | Status: assigned
Internationalization | Resolution:
Severity: Release blocker | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:6>
Django
Reporter: nijel | Owner: claudep
Component: | Version: 1.7
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Claude Paroz <claude@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8b4cc9df9c0760eb4896f1423b6119bdad5674c6"]:
{{{
#!CommitTicketReference repository=""
revision="8b4cc9df9c0760eb4896f1423b6119bdad5674c6"
Fixed #23583 -- More selectively ignored static/media roots
Fixed a regression introduced by 28efafa24c.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:7>
Django
Reporter: nijel | Owner: claudep
Type: Bug | Status: closed
Component: | Version: 1.7
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"d5a273eadb00ee3edd7e81d373b7237220b42571"]:
{{{
#!CommitTicketReference repository=""
revision="d5a273eadb00ee3edd7e81d373b7237220b42571"
[1.7.x] Fixed #23583 -- More selectively ignored static/media roots
Fixed a regression introduced by 28efafa24c.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
Backport of 8b4cc9df9c from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:8>
Django
Reporter: nijel | Owner: claudep
Type: Bug | Status: closed
Component: | Version: 1.7
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by normanjaeckel):
If STATIC_ROOT is None (which is the default), makemessages raises
AttributeError. This bug was introduced with Django 1.7.1. In Django 1.7
it is not there.
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:9>
Django
Reporter: nijel | Owner: claudep
Type: Bug | Status: closed
Component: | Version: 1.7
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by charettes):
normanjaeckel, please go ahead and open a new release blocker ticket
referring to this one to make sure we release 1.7.2 with the appropriate
fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/23583#comment:10>