[Django] #32273: Document AdminSite.unregister()

22 views
Skip to first unread message

Django

unread,
Dec 15, 2020, 2:42:26 PM12/15/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister()
-------------------------------------------------+------------------------
Reporter: Adam (Chainz) Johnson | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------------+------------------------
As suggested by Muskan Vaswan [https://groups.google.com/forum/#!msg
/django-developers/Q8I-0-2Sn4M/LyQP7AaiAQAJ on django-developers]. Several
snippets in the documentation use this function, but it's not documented.
It should be covered next to AdminSite.register().

--
Ticket URL: <https://code.djangoproject.com/ticket/32273>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 15, 2020, 3:09:50 PM12/15/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

#27076

--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:1>

Django

unread,
Dec 15, 2020, 5:09:06 PM12/15/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam (Chainz) Johnson):

Huh. I guess `unregister()` was missed at that time.

--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:2>

Django

unread,
Dec 15, 2020, 5:24:11 PM12/15/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Hasan
Johnson | Ramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* owner: nobody => Hasan Ramezani
* status: new => assigned


Comment:

[https://github.com/django/django/pull/13780 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:3>

Django

unread,
Dec 15, 2020, 5:24:17 PM12/15/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Hasan
Johnson | Ramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:4>

Django

unread,
Dec 15, 2020, 10:54:42 PM12/15/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Hasan
Johnson | Ramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam (Chainz) Johnson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:5>

Django

unread,
Dec 16, 2020, 2:09:07 AM12/16/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Hasan
Johnson | Ramezani
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"bebd4cfa8f5e0d2dff2de5e50d86e849a40f4bb2" bebd4cfa]:
{{{
#!CommitTicketReference repository=""
revision="bebd4cfa8f5e0d2dff2de5e50d86e849a40f4bb2"
Fixed #32273 -- Doc'd AdminSite.unregister().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:6>

Django

unread,
Dec 16, 2020, 2:11:21 AM12/16/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Hasan
Johnson | Ramezani
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"da42df9378ce012d72747fbf1160a6afdf5f5095" da42df93]:
{{{
#!CommitTicketReference repository=""
revision="da42df9378ce012d72747fbf1160a6afdf5f5095"
[3.1.x] Fixed #32273 -- Doc'd AdminSite.unregister().

Backport of bebd4cfa8f5e0d2dff2de5e50d86e849a40f4bb2 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:7>

Django

unread,
Dec 17, 2020, 2:49:41 AM12/17/20
to django-...@googlegroups.com
#32273: Document AdminSite.unregister().
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Hasan
Johnson | Ramezani
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"8f384505eee8ce95667d77cfc2a07d4abe63557c" 8f38450]:
{{{
#!CommitTicketReference repository=""
revision="8f384505eee8ce95667d77cfc2a07d4abe63557c"
Refs #32273 -- Completed test coverage for AdminSite.unregister().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32273#comment:8>

Reply all
Reply to author
Forward
0 new messages