Re: [Django] #34112: Add async interface to Model

27 views
Skip to first unread message

Django

unread,
Oct 23, 2022, 4:15:14 AM10/23/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Leo Tom
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Leo Tom):

* owner: nobody => Leo Tom
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 23, 2022, 11:39:13 PM10/23/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Leo Tom
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

Sounds reasonable, thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:3>

Django

unread,
Oct 26, 2022, 7:45:04 AM10/26/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: (none)
Type: New feature | Status: new

Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Leo Tom):

* owner: Leo Tom => (none)
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:4>

Django

unread,
Oct 28, 2022, 12:32:02 AM10/28/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh

Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Bhuvnesh):

* owner: (none) => Bhuvnesh


* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:5>

Django

unread,
Oct 28, 2022, 1:05:01 AM10/28/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Bhuvnesh):

Hi, i would like to work on this issue, just wanted to know if the
approach will be same as in [https://code.djangoproject.com/ticket/33646
#33646 ] i.e. using {{{sync_to_async}}}?

--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:6>

Django

unread,
Oct 28, 2022, 3:42:04 AM10/28/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Johnson):

> Hi, i would like to work on this issue, just wanted to know if the

approach will be same as in #33646 i.e. using sync_to_async?

Yes.

> Also a regression test for atleast asave() would be really helpful.

Please write the appropriate tests in your PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:7>

Django

unread,
Oct 28, 2022, 10:10:16 PM10/28/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Bhuvnesh):

[https://github.com/django/django/pull/16235 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:8>

Django

unread,
Oct 28, 2022, 10:10:26 PM10/28/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Bhuvnesh):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:9>

Django

unread,
Oct 29, 2022, 4:41:33 AM10/29/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:10>

Django

unread,
Oct 31, 2022, 4:49:27 AM10/31/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Bhuvnesh):

* needs_better_patch: 1 => 0


Comment:

[https://github.com/django/django/pull/16242 UPDATED PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:11>

Django

unread,
Nov 1, 2022, 4:16:11 AM11/1/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:12>

Django

unread,
Nov 2, 2022, 4:15:44 AM11/2/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:13>

Django

unread,
Nov 2, 2022, 5:28:19 AM11/2/22
to django-...@googlegroups.com
#34112: Add async interface to Model
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Bhuvnesh
Type: New feature | Status: closed

Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"d5bcdf858d962d02de925603c17986980f03729a" d5bcdf85]:
{{{
#!CommitTicketReference repository=""
revision="d5bcdf858d962d02de925603c17986980f03729a"
Fixed #34112 -- Added async-compatible interface to Model methods.

Thanks Adam Johnson for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34112#comment:14>

Reply all
Reply to author
Forward
0 new messages