onclick voucher, set focus on field

14 views
Skip to first unread message

Michael Lind Hjulskov

unread,
Aug 12, 2014, 5:17:29 AM8/12/14
to django...@googlegroups.com
Hi

A little suggestion:
after this line

add 
$('#id_code').focus();

Maik Hoepfel

unread,
Aug 12, 2014, 5:45:41 AM8/12/14
to django...@googlegroups.com
Great idea, thanks! You really need to learn how to do pull request;
this would've been another good candidate.
Implemented here:
https://github.com/tangentlabs/django-oscar/commit/b62812f9d02618405d55f6cd612577dcda282006

>
> --
> https://github.com/tangentlabs/django-oscar
> http://django-oscar.readthedocs.org/en/latest/
> https://twitter.com/django_oscar
> ---
> You received this message because you are subscribed to the Google
> Groups "django-oscar" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to django-oscar...@googlegroups.com
> <mailto:django-oscar...@googlegroups.com>.
> Visit this group at http://groups.google.com/group/django-oscar.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-oscar/9ec19ae4-e9a5-47e3-96b6-80e6101ead5e%40googlegroups.com
> <https://groups.google.com/d/msgid/django-oscar/9ec19ae4-e9a5-47e3-96b6-80e6101ead5e%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

Michael Lind Hjulskov

unread,
Aug 12, 2014, 6:19:42 AM8/12/14
to django...@googlegroups.com
glad you could use it
I'd love to learn pull request(and I will eventually), but I have so much I want to learn and build, not the least 1st priority I want to finish my shop dyrefoder.dk asap (so I can start making money again), and that alone is a very huge task for me.
I've actually been a bit depressed after I started building my shop in Oscar. Often thinking about stopping. I'm familiar with php and OScommerse, which for me is a lot easier to get up and running, and there is a more active community around it.
Alternatively I am considering hiring a developer to help me finish my shop, as I'm not so talented developer. I think my talent is to be kindof an architect and shop manager.

Michael 


2014-08-12 11:45 GMT+02:00 Maik Hoepfel <maik.h...@tangentsnowball.com>:
On 12/08/14 10:17, Michael Lind Hjulskov wrote:
Hi

A little suggestion:
after this line
https://github.com/tangentlabs/django-oscar/blob/4c6eef80b179c215b9c8480f99dd89e932fd8f6d/oscar/static/oscar/js/oscar/ui.js#L214

add
$('#id_code').focus();

Great idea, thanks! You really need to learn how to do pull request; this would've been another good candidate.
Implemented here: https://github.com/tangentlabs/django-oscar/commit/b62812f9d02618405d55f6cd612577dcda282006


--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
---
You received this message because you are subscribed to the Google
Groups "django-oscar" group.
To unsubscribe from this group and stop receiving emails from it, send
--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
--- You received this message because you are subscribed to the Google Groups "django-oscar" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages