Wishlists

[sain...@gmail.com]

Hello,

I would like to know if someone is currently working on wishlists:
https://github.com/tangentlabs/django-oscar/wiki/Wishlists
https://github.com/tangentlabs/django-oscar/pull/341

It seems to be planned for django-oscar release 0.6:
https://groups.google.com/d/msg/django-oscar/08Y60qrYSDA/A_5I7mFnZCwJ

The feature looks quite interesting and if nobody is working on it, I can try to merge it myself (but it seems quite a big merge !) and propose a pull request.
However the previous pull request hasn't be pulled, so maybe there are good reasons not to incorporate this feature ?

Regards,

[Maik Hoepfel]

Hi,

I was actually attempting to merge it today, but gave up because it was so messy. I'll give it another attempt next week, running out of time now.

If you want to help, you can write some tests or have a look at this frontend bug https://github.com/tangentlabs/django-oscar/pull/537#issuecomment-15693787

You are also welcome to check out the branch and have a play for it, and give feedback.

Regards,

Maik

[Saint Germain]

Hello,

Thanks for your answer, I will try to checkout the branch and give
some feedbacks this week-end.
The frontend bug seems a bit too difficult for me (not familiar with
oscar enough).

Best regards,

> --
> https://github.com/tangentlabs/django-oscar
> http://django-oscar.readthedocs.org/en/latest/
> https://twitter.com/django_oscar
> ---
> You received this message because you are subscribed to the Google Groups
> "django-oscar" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-oscar...@googlegroups.com.
> Visit this group at http://groups.google.com/group/django-oscar.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-oscar/9cc892ae-59b3-4f05-b5dc-b5c58fd1ff95%40googlegroups.com.
>
> For more options, visit https://groups.google.com/groups/opt_out.

[Saint Germain]

Hello,

As promised, here are a few feedbacks.
I haven't had any problem to make it work and overall it works. However
I had some quirks:
1) I couldn't change the public/private settings of a wishlist, except
by going throught the admin panel (didn't find anywhere else where I
can change that)
2) In user account, wish lists tab, when I click on the button to
select the action, the dropdown menu doesn't diplay completely (instead
of "edit wish list settings", I can only see "edit wish list set")
3) If user is not logged in, the button "Add to wish list doesn't
appear on the product page. IMHO it should appear and redirect to the
login page if the user is not logged in.

I am not sure if you have implemented the following points, but I
haven't found them:
- search public wishlists by customer name or email address
- view another user's public wishlist
- get a "sharing URL" for their wishlist which they can email to
friends (or post on facebook etc)
- can specify a default delivery address for each of their own
wishlists but this is kept hidden from other users (this will
require a checkout change)
- buy an item off another user's wishlist, sending it to either the
default address (for the list) or a new address
- choose the priority of each item in their wishlists (perhaps by
dragging and dropping)

Here is one feature request:
a) maybe we can have an option on the wish list, to allow to send email
when promotions are given on the items on the wish list.

Best regards,


On Fri, 6 Sep 2013 14:40:10 +0200, Saint Germain <sain...@gmail.com>
wrote :

[Maik Hoepfel]

Hello,

thanks for taking the time to review!

> 1) I couldn't change the public/private settings of a wishlist, except
> by going throught the admin panel (didn't find anywhere else where I
> can change that)

Public wishlists were classed as a likely requirement. So I implemented
the hooks for it, but not the actual logic. I will add a comment
regarding that, and hide it from the template. Good spot, thank you.

> 2) In user account, wish lists tab, when I click on the button to
> select the action, the dropdown menu doesn't diplay completely (instead
> of "edit wish list settings", I can only see "edit wish list set")

This is a known issue that will be created on Github once this is merged
in master. It will then be addressed with other FED work before the release.

> 3) If user is not logged in, the button "Add to wish list doesn't
> appear on the product page. IMHO it should appear and redirect to the
> login page if the user is not logged in.

The hiding is intentional, but I see your point. I've talked to David
and we agreed that we'll show the button, but disabled with a tooltip
that one needs to be logged in. Your suggested behaviour should be
straightforward to implement.

> - search public wishlists by customer name or email address
> - view another user's public wishlist
> - get a "sharing URL" for their wishlist which they can email to
> friends (or post on facebook etc)

> - buy an item off another user's wishlist, sending it to either the
> default address (for the list) or a new address

As mentioned above, public wish lists are not included in this release.

> - can specify a default delivery address for each of their own
> wishlists but this is kept hidden from other users (this will
> require a checkout change)

This hasn't been mentioned as a requirement. Oscar has a notion of a
default shipping address; I personally feel like that's sufficient. But
we're always open to discussion.

> - choose the priority of each item in their wishlists (perhaps by
> dragging and dropping)

Sounds great, I'd love a pull request for that.

> a) maybe we can have an option on the wish list, to allow to send email
> when promotions are given on the items on the wish list.

That makes good sense. David and I believe it's not really appropriate
for Oscar core though, because it's a bit specific to the deployment.
Some deployments might use wishlists more as a "Hey grandma, this is
what I want for my birthday" then a personal "Save for later" list.



Thanks again for taking the time, that was really helpful. We're
hopefully merging the wishlists branch this week. You're welcome to send
pull requests if you'd like to see a more feature-rich wishlists app in
Oscar 0.6.


Regards,

Maik


Maik Hoepfel


Tangent Snowball
84-86 Great Portland Street
London
W1W 7NR




www.tangentsnowball.com

Tangent Snowball is a registered trading name of Tangent Marketing Services Limited
Registered Office: 84-86 Great Portland Street, London W1W 7NR
Registered in England Wales Number 4323657

This message contains confidential information and is intended only for the individual named.
If you are not the named addressee you should not disseminate, distribute or copy this e-mail.
Please notify the sender immediately by e-mail if you have received this e-mail by mistake
and delete this e-mail from your system.

[Saint Germain]

On 12 September 2013 14:54, Maik Hoepfel

<maik.h...@tangentsnowball.com> wrote:

>> - search public wishlists by customer name or email address
>> - view another user's public wishlist
>> - get a "sharing URL" for their wishlist which they can email to
>> friends (or post on facebook etc)
>> - buy an item off another user's wishlist, sending it to either the
>> default address (for the list) or a new address
> As mentioned above, public wish lists are not included in this release.
>
>> - can specify a default delivery address for each of their own
>> wishlists but this is kept hidden from other users (this will
>> require a checkout change)
>
> This hasn't been mentioned as a requirement. Oscar has a notion of a default
> shipping address; I personally feel like that's sufficient. But we're always
> open to discussion.
>
>> - choose the priority of each item in their wishlists (perhaps by
>> dragging and dropping)
>
> Sounds great, I'd love a pull request for that.
>

Hum we may have a misunderstanding there. These requirements/request
don't come from me. I have taken them from this page:
https://github.com/tangentlabs/django-oscar/wiki/Wishlists
I just tested oscar wishlist branch against these requirements and
reported the result.

>> a) maybe we can have an option on the wish list, to allow to send email
>> when promotions are given on the items on the wish list.
>
> That makes good sense. David and I believe it's not really appropriate for
> Oscar core though, because it's a bit specific to the deployment. Some
> deployments might use wishlists more as a "Hey grandma, this is what I want
> for my birthday" then a personal "Save for later" list.
>

Ok I understand. It makes sense to keep this "mailing" out of oscar.

> Thanks again for taking the time, that was really helpful. We're hopefully
> merging the wishlists branch this week. You're welcome to send pull requests
> if you'd like to see a more feature-rich wishlists app in Oscar 0.6.
>

You are welcome. I just started with django/oscar/css/github and
website development in general, so everything is still a bit confused
in my head right now.
I think I will start with a simpler pull request (see my proposition
on spam protection) otherwise you may be shocked by the quality for
the code... ;-)

Regards,

[Maik Hoepfel]

Ah, you're absolutely correct with the specs. That was something we must've discussed internally and never put into writing.

Oscar is a pretty advanced project to work with if you're just starting web development. So take your time :)

Cheers,

Maik

[Saint Germain]

Hello Maik,

Even if it is advanced, it seems that Oscar includes a lot of good
practices in Django development, so I am learning a lot by delving
into its code: it is really a pleasure to work with !

Regards,

> --
> https://github.com/tangentlabs/django-oscar
> http://django-oscar.readthedocs.org/en/latest/
> https://twitter.com/django_oscar
> ---
> You received this message because you are subscribed to the Google Groups
> "django-oscar" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-oscar...@googlegroups.com.
> Visit this group at http://groups.google.com/group/django-oscar.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/django-oscar/1c9916c0-e02d-4d03-a8c2-0b1dba4520db%40googlegroups.com.