Fellow Reports - July 2019

125 views
Skip to first unread message

Mariusz Felisiak

unread,
Jul 8, 2019, 4:08:30 AM7/8/19
to Django developers (Contributions to Django itself)
Week ending July 7, 2019.

Released Django 2.2.3, 2.1.10, and 1.11.22.

Triaged:

https://code.djangoproject.com/ticket/30608 - Email messages crash on non-unicode hostnames. (accepted)
https://code.djangoproject.com/ticket/30609 - Add class removed as part of Django 1.9 release. (invalid)
https://code.djangoproject.com/ticket/30610 - Model.full_clean() doesn't prevetn invalid (null) values when blank=True. (duplicate)
https://code.djangoproject.com/ticket/30611 - Add reversal options object to django migration constructs/class constructors. (duplicate)
https://code.djangoproject.com/ticket/30612 - cached_property breaks type checking (invalid)
https://code.djangoproject.com/ticket/7537 - Make RegexURLResolver easier to subclass. (invalid)
https://code.djangoproject.com/ticket/30613 - Move index name checks from Index.__init__ into system checks. (accepted)
https://code.djangoproject.com/ticket/30615 - Add row_to_json(row) postgresql function. (wontfix)
https://code.djangoproject.com/ticket/30616 - CommandTemplate Behavior Is Inconsistent. (invalid)
https://code.djangoproject.com/ticket/30620 - A full example in documentation is not PEP8 compliant. (accepted)

Reviewed/committed:
https://github.com/django/django/pull/11526 - Fixed #30589 -- Clarified that urlize should be applied only to email addresses without single quotes.
https://github.com/django/django/pull/11527 - Fixed #30595 -- Added error message when no objects found to sql* management commands.
https://github.com/django/django/pull/11525 - Fixed #30604 -- Made mail_admins()/mail_managers() raise ValueError if ADMINS/MANAGERS is set incorrectly.
https://github.com/django/django/pull/11530 - Fixed #28588 -- Doc'd User.has_perm() & co. behavior for active superusers.
https://github.com/django/django/pull/11501 - Fixed #27801 -- Made createsuperuser fall back to environment variables for password and required fields.
https://github.com/django/django/pull/11532 - Fixed #30608 -- Fixed non-unicode EmailMessage crash when domain name for localhost is non-ASCII.
https://github.com/django/django/pull/11333 - Fixed #29744 -- Fixed caching of URLResolver for a default URLconf.
https://github.com/django/django/pull/11534 - Fixed #30596 -- Fixed SplitArrayField.has_changed() for non-string base fields.
https://github.com/django/django/pull/11515 - Fixed #28667 -- Clarified how to override list of forms fields for custom UserAdmin with a custom user model.
https://github.com/django/django/pull/11124 - Fixed #28581 -- Moved django.core.paginator documentation to API Reference.
https://github.com/django/django/pull/11537 - Fixed #30600 -- Clarified that ValueError raised by converter.to_python() means no match.
https://github.com/django/django/pull/11539 - Fixed #30613 -- Moved index name validation to system checks.

Best regards,
Mariusz

Mariusz Felisiak

unread,
Jul 15, 2019, 5:19:56 AM7/15/19
to Django developers (Contributions to Django itself)
Week ending July 14, 2019.

Triaged:
https://code.djangoproject.com/ticket/30623 - Remove duplicate call to `self.update` on RequestContext. (invalid)
https://code.djangoproject.com/ticket/30624 - Use numbered list reStructuredText syntax throughout the docs. (wontfix)
https://code.djangoproject.com/ticket/30622 - A better admin interface for non-relational databases like MongoDB. (wontfix)
https://code.djangoproject.com/ticket/30617 - test_check_constraints sometimes fails with no such table error. (worksforme)
https://code.djangoproject.com/ticket/30621 - CheckConstraint crash with __contains lookup on DateTimeRangeFields. (accepted)
https://code.djangoproject.com/ticket/30618 - AppConfig.name should be a full python path when using the optional directory. (accepted)
https://code.djangoproject.com/ticket/30614 - Add constraint name validation to system checks. (wontfix)
https://code.djangoproject.com/ticket/30626 - InlineModelAdmin fails of an empty form when DecimalField has default and blank=True. (invalid)
https://code.djangoproject.com/ticket/30628 - order_by() on union() querysets results with wrong ordering when the same field type is presented multiple times. (accepted)
https://code.djangoproject.com/ticket/30627 - In multi-table inheritance, querying with invalid pk raises different exception depending on the inheritance level. (fixed)
https://code.djangoproject.com/ticket/30629 - Add Redis to django.core.cache. (duplicate)
https://code.djangoproject.com/ticket/30630 - MemoryError raised by inspectdb executed on Oracle 12c. (invalid)
https://code.djangoproject.com/ticket/30631 - Prefixing Q Objects. (wontfix)
https://code.djangoproject.com/ticket/30633 - Group by concat(field1,field2) producing wrong result. (invalid)
https://code.djangoproject.com/ticket/30634 - "manage.py runserver" does not respect SCRIPT_NAME header. (wontfix)
https://code.djangoproject.com/ticket/13896 - Change language to dynamic attribute in syndication feed generator (duplicate)

Reviewed/committed:
https://github.com/django/django/pull/11544 - Fixed #30620 -- Made an example of admin-compliant custom user app pep8 compliant.
https://github.com/django/django/pull/11462 - Refs #29444 -- Added support for fetching a returned non-integer insert values on Oracle.
https://github.com/django/django/pull/11279 - Fixed #30397 -- Added app_label/class interpolation for names of indexes and constraints.
https://github.com/django/django/pull/11550 - Fixed #30628 -- Adjusted expression identity to differentiate bound fields.
https://github.com/django/django/pull/11551 - Fixed #30543 -- Fixed checks of ModelAdmin.list_display for fields accessible only via instance.
https://github.com/django/django/pull/11543 - Fixed #30619 -- Made runserver --nothreading use single threaded WSGIServer.
https://github.com/django/django/pull/11354 - Fixed #28289 -- Fixed crash of RawSQL annotations on inherited model fields.
https://github.com/django/django/pull/11556 - Doc'd --no-input option for createsuperuser.
https://github.com/django/django/pull/11555 - Fixed #30557 -- Fixed crash of ordering by ptr fields when Meta.ordering contains expressions.
https://github.com/django/django/pull/11560 - Fixed #30602 -- Made Extract raise ValueError when using unsupported lookups for DurationField.

Authored:
https://github.com/django/django/pull/11553 - Fixed #30621 -- Fixed crash of __contains lookup for Date/DateTimeRangeField when the right hand side is the same type.
https://github.com/django/django/pull/11559 - Refs #30557 -- Fixed crash of ordering by ptr fields when Meta.ordering contains F() expressions.
https://github.com/django/djangoproject.com/pull/924 - Updated to django-money==0.15.
https://github.com/django/django/pull/11562 - Simplified DateTimeRangeContains by making it subclass PostgresSimpleLookup.
https://github.com/django/django/pull/11563 - Simplified RangeContainedBy by making it subclass PostgresSimpleLookup.

Best regards,
Mariusz

Mariusz Felisiak

unread,
Jul 22, 2019, 2:46:40 AM7/22/19
to Django developers (Contributions to Django itself)
Week ending July 21, 2019.

Triaged:
https://code.djangoproject.com/ticket/30636 - mysqldump crash when --defaults-file is not given before other options. (accepted)
https://code.djangoproject.com/ticket/30637 - SearchVectorField and SearchVector should be combinable. (accepted)
https://code.djangoproject.com/ticket/30639 - Raise an error on unsupported operations following QuerySet.union(). (duplicate)
https://code.djangoproject.com/ticket/30640 - createsuperuser crashes when a custom user model contains required fields that overlap with default command options. (wontfix)
https://code.djangoproject.com/ticket/30641 - Update docs for using CSRF with Ajax. (wontfix)
https://code.djangoproject.com/ticket/30618 - AppConfig.name should be a full python path when using the optional directory. (wontfix)
https://code.djangoproject.com/ticket/30643 - Docs incorrectly state that time zone support is disabled by default. (duplicate)
https://code.djangoproject.com/ticket/30642 - Unable to include default value in column_sql when creating new model. (invalid)
https://code.djangoproject.com/ticket/30329 - ImproperlyConfigured exceptions should be raised immediately. (fixed)
https://code.djangoproject.com/ticket/30000 - QuerySet constructed with .union() should raise an exception on unsupported filter() attempt. (duplicate)https://code.djangoproject.com/ticket/30644 - Postgres introspection don't filter on visible objects. (accepted)
https://code.djangoproject.com/ticket/30646 - close_if_unusable_or_obsolete fails to close unusable connections. (wontfix)
https://code.djangoproject.com/ticket/30648 - Overriding get_context_data() is unnecessary in the "Using FormMixin with DetailView" example. (acce[ted)
https://code.djangoproject.com/ticket/28439 - When() crashes with ValidationError with models using UUID as primary key. (fixed)
https://code.djangoproject.com/ticket/30649 - Implement MakeValid() for non-column values. (wontfix)
https://code.djangoproject.com/ticket/30638 - Allow the per-database TIME_ZONE option on databases that support timezones. (wontfix)
https://code.djangoproject.com/ticket/30083 - Model instance state not correctly set when initializing a model with Model.from_db() (wontfix)

Reviewed/committed:
https://github.com/django/django/pull/11565 - Fixed explanation of how to automatically create tables in database.
https://github.com/django/django/pull/11567 - Fixed #30636 -- Fixed options ordering when cloning test database on MySQL.
https://github.com/django/django/pull/10478 - Fixed #29824 -- Added support for database exclusion constraints on PostgreSQL.
https://github.com/django/django/pull/11575 - Fixed #30648 -- Removed unnecessary overriding get_context_data() from mixins with CBVs docs.
https://github.com/django/django/pull/11566 - Fixed #30593 -- Added support for check constraints on MariaDB 10.2+.
https://github.com/django/djangoproject.com/pull/904 - Fixed #902 -- Updated to Django==2.2.3
https://github.com/django/djangoproject.com/pull/893 - Trimmed search_results translation messages.

Reviewed:
https://github.com/django/django/pull/11452 - Fixed #12990 -- Added JSONField model field.

Authored:
https://github.com/django/django/pull/11574 - Refs #30547 -- Clarified that partial UniqueConstraints don't affect model validation.
https://github.com/django/django/pull/11576 - Refs #30083 -- Clarified database state of instances in signals.pre_init docs.
https://github.com/django/django/pull/11577 - Simplified get_key_columns()/get_relations() introspection methods for PostgreSQL.

Best regards,
Mariusz

Mariusz Felisiak

unread,
Jul 29, 2019, 3:55:35 AM7/29/19
to Django developers (Contributions to Django itself)
Week ending July 28, 2019.

Triaged:
https://code.djangoproject.com/ticket/30651 - __eq__ should return NotImplemented when equality cannot be checked (accepted)
https://code.djangoproject.com/ticket/23524 - Allow to set TIME_ZONE option on databases that support time zones. (accepted)
https://code.djangoproject.com/ticket/30652 - ResolvedOuterRef object has no attribute contains_aggregate. (duplicate)
https://code.djangoproject.com/ticket/30653 - Annotate a whole ORM object with Subquery instead of just a column. (wontfix)
https://code.djangoproject.com/ticket/30654 - Optimize session cache backend KEY_PREFIX settings to support dynamic configuration. (invalid)
https://code.djangoproject.com/ticket/30655 - len(queryset) and queryset.count() return different results. (wontfix)
https://code.djangoproject.com/ticket/30656 - The bulk_update method should be mentioned in the database access optimization section of the docs. (accepted)
https://code.djangoproject.com/ticket/30657 - Allow model Fields to override their descriptor. (accepted)
https://code.djangoproject.com/ticket/30658 - Unexpected result using union querysets with annotated columns. (duplicate)
https://code.djangoproject.com/ticket/30659 - Annotate ignored when using after union. (duplicate)
https://code.djangoproject.com/ticket/30663 - How to iuse the if to verify a self define filter value. (invalid)

Reviewed/committed:
https://github.com/django/django/pull/11511 - Fixed #30644 -- Made introspection use pg_table_is_visible() instead of filtering by public schema on PostgreSQL
https://github.com/django/django/pull/11583 - Fixed #30506 -- Fixed crash of autoreloader when path contains null characters.
https://github.com/django/django/pull/11581 - Improved error message when index in __getitem__() is invalid.
https://github.com/django/django/pull/11584 - Fixed #30647 -- Fixed crash of autoreloader when extra directory cannot be resolved.
https://github.com/django/django/pull/11589 - Fixed #30657 -- Allowed customizing Field's descriptors with a descriptor_class attribute.
https://github.com/django/django/pull/11591 - Fixed #27995 -- Added error messages on unsupported operations following union(), intersection(), and difference().
https://github.com/django/django/pull/11592 - Fixed #30567 -- Made WSGIHandler pass FileResponse.block_size to wsgi.file_wrapper.
https://github.com/django/django/pull/11587 - Refs #28147 -- Fixed setting of OneToOne and Foreign Key fields to None when using attnames.
https://github.com/django/django/pull/11599 - Fixed #30552 -- Fixed loss of SRID when calling reverse() on LineString/Point.
https://github.com/django/djangoproject.com/pull/921 - Used SVG fundraising heart.

Authored:

Best regards,
Mariusz
Reply all
Reply to author
Forward
0 new messages